docs(glossary): general cleanup and fix links #2100
Conversation
|
@kwalrath @wardbell @Foxandxss : Ready for review. Best viewed by ignoring whitespace.
|
chalin
force-pushed
the
chalin-glossary-rework-0812
branch
from
7f0a6bd to
c045020
Compare
| application's top level "root" [Component](#component) and optionally | ||
| registers service [providers](#provider) with the [dependency injection | ||
| system](#dependency-injection). |
There was a problem hiding this comment.
Isn't this information pre-RC5?
There was a problem hiding this comment.
For some reason I was under the impression that the old definition was appearing in the JS glossary, but you are correct, it should not. I'll remove it and rebase.
|
This needs rebase, but I like what I see. |
chalin
force-pushed
the
chalin-glossary-rework-0812
branch
from
c045020 to
bdd018c
Compare
|
|
||
| block annotation-defn | ||
| :marked | ||
| There are different kinds of annotation in Dart. Unqualified use of the |
There was a problem hiding this comment.
Let's reword the first two sentences to remove the "There are" and give a hint as to what other uses of "annotation" might be. (The first sentence stopped me cold, as I tried to recall what the other kinds of annotations were.) Maybe:
When unqualified, _annotation_ refers to a Dart [metadata annotation][metadata] (as opposed to, say, a type annotation).
|
Aside from what I marked, LGTM. |
This commit addresses issues with the glossary for all languages (JS, TS, Dart). Fixes angular#1123, angular#1838, angular#2036. This was originally started as post-RC5 Dart resync, but since mixing Harp partials with Jade mixins can be problematic, this commit does a general cleanup of the 3 x 2 = 6 glossary files (found in `{ts,js,dart}/latest/{.,guide}`). This commit builds upon angular#2098 (which created the first `ts/_cache` copy of the glossary), but doesn't really depend on it.
chalin
force-pushed
the
chalin-glossary-rework-0812
branch
from
bdd018c to
de8fb3f
Compare
|
Blocked by @kwalrath until current glossary review is done |
|
Actually, I wanted this change in before the editor looks at it. Pushing the updated site now... |
This commit addresses issues with the glossary for all languages (JS, TS, Dart).
Fixes #1123, #1838, #2036.
Contributes to #1508.
This was originally started as post-RC5 Dart resync, but since mixing Harp partials with Jade mixins can be problematic, this commit does a general cleanup of the 3 x 2 = 6 glossary files (found in
{ts,js,dart}/latest/{.,guide}).This commit builds upon #2098 (which created the first
ts/_cachecopy of the glossary), but doesn't really depend on it.