Skip to content

docs: update documentation for universal #7803

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 6, 2017
Merged

docs: update documentation for universal #7803

merged 2 commits into from
Oct 6, 2017

Conversation

MarkPieszak
Copy link
Contributor

Replacement for PR #7796

Update documentation to show TypeScript webpack build for node server, as well as a few gotchas & important things to have setup to have it bundle normal applications properly.

cc/ @vikerman

@hansl
Copy link
Contributor

hansl commented Sep 24, 2017

I'll wait for @vikerman 's approval before merging this, but LGTM.

Copy link
Contributor

@vikerman vikerman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one change

- Http calls will be executed **twice**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think this is the place to mention all of Universal Gotchas. We should just mention any Universal CLI gotchas if any,

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed! 👍

@hansl hansl merged commit eed13cf into angular:master Oct 6, 2017
dond2clouds pushed a commit to d2clouds/speedray-cli that referenced this pull request Apr 23, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants