-
Notifications
You must be signed in to change notification settings - Fork 12k
docs: update documentation for universal #7803
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'll wait for @vikerman 's approval before merging this, but LGTM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one change
- Http calls will be executed **twice** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is the place to mention all of Universal Gotchas. We should just mention any Universal CLI gotchas if any,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed! 👍
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Replacement for PR #7796
Update documentation to show TypeScript webpack build for node server, as well as a few gotchas & important things to have setup to have it bundle normal applications properly.
cc/ @vikerman