-
Notifications
You must be signed in to change notification settings - Fork 12k
docs: Update Universal Story to include module map #7739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@alxhub can you have a look? |
03e79f6
to
e12c3a5
Compare
@@ -127,7 +138,7 @@ Then, remove the `"polyfills"` key - those aren't needed on the server, and adju | |||
"root": "src", | |||
// Build to dist-server instead of dist. This prevents | |||
// client and server builds from overwriting each other. | |||
"outDir": "dist-server", | |||
"outDir": "dist/dist-server", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bad idea to put the Universal files in the same directory as normal build, I've tried this option and it causes issues. Better stay in another directory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion @cyrilletuzi I'll apply those changes now 😄 Just out of curiosity what are the issues caused by having it within the dist?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't remember exactly, but good chances it was a problem of wrong import paths (as it's in a subdirectory) or a conflict on some building steps as files are in the same main directory.
6b9d58a
to
e287e8b
Compare
e287e8b
to
3af138f
Compare
@nguniversal/module-map-ngfactory-loader has been release and with it, support for Lazy loading! This PR updates the existing story to guide users how they can use this functionality.
4c86c34
to
b17a484
Compare
I used this answer, it is about firebase deploy, but main logic is simple https://hackernoon.com/deploy-angular-universal-w-firebase-ad70ea2413a1 |
Overwritten by #7803 |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
@nguniversal/module-map-ngfactory-loader
has been release and with it, support for Lazy loading!This PR updates the existing story to guide users how they can use this functionality.
Closes: #7706