Skip to content

docs: Update Universal Story to include module map #7739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

RicardoVaranda
Copy link
Contributor

@RicardoVaranda RicardoVaranda commented Sep 19, 2017

@nguniversal/module-map-ngfactory-loader has been release and with it, support for Lazy loading!

This PR updates the existing story to guide users how they can use this functionality.

Closes: #7706

@filipesilva
Copy link
Contributor

@alxhub can you have a look?

@@ -127,7 +138,7 @@ Then, remove the `"polyfills"` key - those aren't needed on the server, and adju
"root": "src",
// Build to dist-server instead of dist. This prevents
// client and server builds from overwriting each other.
"outDir": "dist-server",
"outDir": "dist/dist-server",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bad idea to put the Universal files in the same directory as normal build, I've tried this option and it causes issues. Better stay in another directory.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the suggestion @cyrilletuzi I'll apply those changes now 😄 Just out of curiosity what are the issues caused by having it within the dist?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember exactly, but good chances it was a problem of wrong import paths (as it's in a subdirectory) or a conflict on some building steps as files are in the same main directory.

@nguniversal/module-map-ngfactory-loader has been release and with it, support for Lazy loading!

This PR updates the existing story to guide users how they can use this functionality.
@MarkPieszak
Copy link
Contributor

Didn't see this PR in there, but added TypeScript (changes similar to these) and other fixes @vikerman requested here: #7796

@genyklemberg
Copy link

I used this answer, it is about firebase deploy, but main logic is simple https://hackernoon.com/deploy-angular-universal-w-firebase-ad70ea2413a1

@RicardoVaranda
Copy link
Contributor Author

Overwritten by #7803

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lazy Loading with Universal
7 participants