Skip to content

Improve docs/story for universal builds #7388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
BioPhoton opened this issue Aug 14, 2017 · 10 comments
Closed

Improve docs/story for universal builds #7388

BioPhoton opened this issue Aug 14, 2017 · 10 comments
Assignees
Labels
area: docs Related to the documentation help wanted

Comments

@BioPhoton
Copy link

BioPhoton commented Aug 14, 2017

Bug Report or Feature Request

- [X] documentation thing

Versions.

@angular/cli: 1.3.0
node: 6.11.1
os: win32 x64
@angular/animations: 4.3.4
@angular/common: 4.3.4
@angular/compiler: 4.3.4
@angular/core: 4.3.4
@angular/forms: 4.3.4
@angular/http: 4.3.4
@angular/platform-browser: 4.3.4
@angular/platform-browser-dynamic: 4.3.4
@angular/router: 4.3.4
@angular/cli: 1.3.0
@angular/compiler-cli: 4.3.4
@angular/language-service: 4.3.4
@angular/platform-server: 4.3.4

Repro steps.

I followed the Story about universal rendering.
It was all clear but i guess the last step testing the whole thing is not really good explained.

Where to place the code, how to serve this and so on. I think this information would make it more complete and helpful.

The log given by the failure.

Nothing

Desired functionality.

Documentation on how to test it. => I want to see the rendered page (html)

Mention any other details that might be useful.

No

@maxisam
Copy link
Contributor

maxisam commented Aug 17, 2017

Also, is there any chance to add some documents for how to make universal to work with asp.net core?

@dockleryxk
Copy link

@maxisam does this help at all? I know jack squat about asp.net, but I saw this earlier. Hopefully it helps!

@BioPhoton
Copy link
Author

I guess i tiny script to run it with node ./universal-test.js would be enough to test it.

@maxisam
Copy link
Contributor

maxisam commented Aug 21, 2017

@dockleryxk thanks.

It works now! I can confirm that it works with asp.net core.

@filipesilva filipesilva added area: docs Related to the documentation help wanted labels Aug 24, 2017
@maxisam
Copy link
Contributor

maxisam commented Sep 11, 2017

For future reference: Here is the repo https://github.com/maxisam/DotNetCoreNgCli/tree/master/dotNetCoreNgCli

@RicardoVaranda
Copy link
Contributor

RicardoVaranda commented Sep 19, 2017

Hi @alxhub , I've submitted a PR to match your specifications and lazy loading included, let me know if you have any suggestions on how to further improve it #7534

@CaerusKaru
Copy link
Member

Should be closed by #7803

@tiaguinho
Copy link
Contributor

@alxhub like @CaerusKaru says I think this should be closed.

@BioPhoton
Copy link
Author

It's in the cli now... :-)

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: docs Related to the documentation help wanted
Projects
None yet
Development

No branches or pull requests

8 participants