fix(@ngtools/webpack): avoid resetting emit skipped flag when no Type… #14778
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
added
target: patch
… an emit There can be a number of reason why `_emitSkipped` is set to true these are: - Errors have been encountered - Changes are outside of TS compilations such as HTML and CSS in JIT mode We only want to run a full JIT emit when; - There hasn't been a success emit - When a large number of files have changed - First run If a subsequent JIT build fails we shouldn't do a full emit either as we will transpile only the files that changes after the success build https://github.com/angular/angular-cli/blob/64243919c10c33775be71010efd5ae69622a728f/packages/ngtools/webpack/src/angular_compiler_plugin.ts#L1029-L1031 Fixes #14775
clydin
approved these changes
Jun 14, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There can be a number of reason why
_emitSkippedis set to true these are:We only want to run a full JIT emit when;
If a subsequent JIT build fails we shouldn't do a full emit either as we will transpile only the files that changes after the success build
angular-cli/packages/ngtools/webpack/src/angular_compiler_plugin.ts
Lines 1029 to 1031 in 6424391
Fixes #14775