-
Notifications
You must be signed in to change notification settings - Fork 12k
Rebuild time is not stable anymore in 8.0.3 #14775
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Labels
area: @ngtools/webpack
freq4: critical
Happens to many users every day
severity5: regression
type: bug/fix
Milestone
Comments
mgechev
pushed a commit
that referenced
this issue
Jun 14, 2019
… an emit There can be a number of reason why `_emitSkipped` is set to true these are: - Errors have been encountered - Changes are outside of TS compilations such as HTML and CSS in JIT mode We only want to run a full JIT emit when; - There hasn't been a success emit - When a large number of files have changed - First run If a subsequent JIT build fails we shouldn't do a full emit either as we will transpile only the files that changes after the success build https://github.com/angular/angular-cli/blob/64243919c10c33775be71010efd5ae69622a728f/packages/ngtools/webpack/src/angular_compiler_plugin.ts#L1029-L1031 Fixes #14775
mgechev
pushed a commit
that referenced
this issue
Jun 14, 2019
… an emit There can be a number of reason why `_emitSkipped` is set to true these are: - Errors have been encountered - Changes are outside of TS compilations such as HTML and CSS in JIT mode We only want to run a full JIT emit when; - There hasn't been a success emit - When a large number of files have changed - First run If a subsequent JIT build fails we shouldn't do a full emit either as we will transpile only the files that changes after the success build https://github.com/angular/angular-cli/blob/64243919c10c33775be71010efd5ae69622a728f/packages/ngtools/webpack/src/angular_compiler_plugin.ts#L1029-L1031 Fixes #14775
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
ikjelle
pushed a commit
to ikjelle/angular-cli
that referenced
this issue
Mar 26, 2024
… an emit There can be a number of reason why `_emitSkipped` is set to true these are: - Errors have been encountered - Changes are outside of TS compilations such as HTML and CSS in JIT mode We only want to run a full JIT emit when; - There hasn't been a success emit - When a large number of files have changed - First run If a subsequent JIT build fails we shouldn't do a full emit either as we will transpile only the files that changes after the success build https://github.com/angular/angular-cli/blob/64243919c10c33775be71010efd5ae69622a728f/packages/ngtools/webpack/src/angular_compiler_plugin.ts#L1029-L1031 Fixes angular#14775
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
area: @ngtools/webpack
freq4: critical
Happens to many users every day
severity5: regression
type: bug/fix
🐞 Bug report
Using @ngtools/webpack 8.0.3, every second rebuild time is high.
Command (mark with an
x
)Is this a regression?
Yes, since 8.0.1. First appeared in 8.0.2 (see #14719), 8.0.3 aimed to fix it, but the fix is half-measure (literally).
Description
Launch
ng serve
, wait for the first build, then touch a component html file and wait its rebuild. I did this few times and wrote down the rebuild times.Version
8.0.3
:First rebuild is fast, but every second rebuild is slow.
Version:
8.0.2
:Every rebuild is slow.
Version:
8.0.1
:Every rebuild is fast.
🌍 Your Environment
Anything else relevant?
Sass: yes, fibers is installed
Operating system: windows 10
The text was updated successfully, but these errors were encountered: