Perf regression in @ngtools/webpack 8.0.2

[mattlewis92]

🐞 Bug report

Command (mark with an x)

- [ ] new
- [ ] build
- [x] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [ ] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Is this a regression?

Yes, the previous version in which this bug was not present was: 8.0.1

Description

When upgrading to the latest cli I noticed that our local rebuild times in JIT went from ~7s to ~24s. I managed to narrow it down to this commit: d61b252 Manually reverting in the source of ngtools/webpack and the re-build times went back to normal

🔬 Minimal Reproduction

Sorry I can't really share our repo, but I hope that it's enough to identify the commit that caused the regression.

🔥 Exception or Error

N/A

🌍 Your Environment

Angular CLI: 8.0.2
Node: 12.4.0
OS: darwin x64
Angular: 8.0.0
... animations, cdk, common, compiler, compiler-cli, core, forms
... language-service, platform-browser, platform-browser-dynamic
... router, service-worker

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.800.2
@angular-devkit/build-angular     0.800.2
@angular-devkit/build-optimizer   0.800.2
@angular-devkit/build-webpack     0.800.2
@angular-devkit/core              8.0.2
@angular-devkit/schematics        8.0.2
@angular/cli                      8.0.2
@ngtools/webpack                  8.0.2
@schematics/angular               8.0.2
@schematics/update                0.800.2
rxjs                              6.5.2
typescript                        3.4.5
webpack                           4.30.0

Anything else relevant?
N/A

[alan-agius4]

Hi, can you confirm if the rebuilds increase only when the previous compilation had an error, or the increase is constant for you?

Thanks.

[mattlewis92]

The increase is constant for me, every compilation previously succeeded without error.

[alan-agius4]

Thanks for the info. That is strange cause that flag should get set to false upon a successful build and true upon an invalid build.

I’ll try to look at it tomorrow and see if I am able to replicate.

[mattlewis92]

Sweet, thanks! Let me know if you can't reproduce and I'll debug locally to see why that flag's being set to true.

[mattlewis92]

Thanks for fixing this so fast! 😄

[kondi]

The fix does not look perfect, see #14775

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}