Skip to content

fix(@ngtools/webpack): avoid resetting emit skipped flag before emit #14720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 10, 2019
Merged

fix(@ngtools/webpack): avoid resetting emit skipped flag before emit #14720

merged 1 commit into from
Jun 10, 2019

Conversation

clydin
Copy link
Member

@clydin clydin commented Jun 10, 2019

Fixes #14719

@clydin clydin added the target: patch This PR is targeted for the next patch release label Jun 10, 2019
@clydin clydin requested a review from alan-agius4 June 10, 2019 17:53
alan-agius4
alan-agius4 approved these changes Jun 10, 2019
View reviewed changes
Copy link
Collaborator

@alan-agius4 alan-agius4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for looking at this so fast. You beat me to it :)

@kyliau kyliau merged commit 50a172a into angular:master Jun 10, 2019
@clydin clydin deleted the fix-skip-emit branch June 10, 2019 20:53
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alan-agius4 alan-agius4 alan-agius4 approved these changes

Assignees
No one assigned
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Perf regression in @ngtools/webpack 8.0.2
4 participants
@clydin @alan-agius4 @kyliau @googlebot