Skip to content

fix(@ngtools/webpack): avoid resetting emit skipped flag when no Type… #14778

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 14, 2019
Merged

fix(@ngtools/webpack): avoid resetting emit skipped flag when no Type… #14778

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion packages/ngtools/webpack/src/angular_compiler_plugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,9 @@ export class AngularCompilerPlugin {
private _platform: PLATFORM;
private _JitMode = false;
private _emitSkipped = true;
// This is needed because if the first build fails we need to do a full emit
// even whe only a single file gets updated.
private _hadFullJitEmit: boolean | undefined;
private _changedFileExtensions = new Set(['ts', 'tsx', 'html', 'css', 'js', 'json']);

// Webpack plugin.
Expand Down Expand Up @@ -1196,14 +1199,15 @@ export class AngularCompilerPlugin {
'AngularCompilerPlugin._emit.ts', diagMode));

if (!hasErrors(allDiagnostics)) {
if (this._firstRun || changedTsFiles.size > 20 || this._emitSkipped) {
if (this._firstRun || changedTsFiles.size > 20 || !this._hadFullJitEmit) {
emitResult = tsProgram.emit(
undefined,
undefined,
undefined,
undefined,
{ before: this._transformers },
);
this._hadFullJitEmit = !emitResult.emitSkipped;
allDiagnostics.push(...emitResult.diagnostics);
} else {
for (const changedFile of changedTsFiles) {
Expand Down