Skip to content

refactor(@schematics/update): cleanup/optimize npm fetch #12526

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 31, 2018
Merged

refactor(@schematics/update): cleanup/optimize npm fetch #12526

merged 1 commit into from
Oct 31, 2018

Conversation

clydin
Copy link
Member

@clydin clydin commented Oct 9, 2018 •
edited
Loading

massive code reduction as well as built-in caching
broader support for .npmrc options

@clydin clydin added target: major This PR is targeted for the next major release state: blocked labels Oct 9, 2018
@clydin clydin added the needs: discussion On the agenda for team meeting to determine next steps label Oct 18, 2018
@alexeagle
Copy link
Contributor

@hansl do you know whether this validation check is intended just for google3 import? This licensing violation is for a package we don't use in google3.

@alan-agius4 alan-agius4 mentioned this pull request Oct 23, 2018
Closed
@ngbot
Copy link

ngbot bot commented Oct 23, 2018

Hi @clydin! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

@clydin clydin mentioned this pull request Oct 25, 2018
Closed
@alexeagle alexeagle removed the needs: discussion On the agenda for team meeting to determine next steps label Oct 25, 2018
@alexeagle
Copy link
Contributor

Yes, we need to wait for the license to get fixed. Or, we could fork two projects as a workaround but that's painful.

@clydin clydin mentioned this pull request Oct 26, 2018
Closed
@Airblader
Copy link

Upstream has been resolved. Just wanted to notify since removing the blocked label alone probably didn't do that.

@kyliau kyliau merged commit 55f015f into angular:master Oct 31, 2018
@clydin clydin deleted the optimize-update branch November 1, 2018 00:45
This was referenced Nov 12, 2018
Closed
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@filipesilva filipesilva filipesilva approved these changes

Assignees
No one assigned
Labels
target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@clydin @alexeagle @Airblader @filipesilva @kyliau @googlebot