Skip to content

ng update doesn't work with http packages in package.json #12694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
fr0 opened this issue Oct 22, 2018 · 3 comments
Closed

ng update doesn't work with http packages in package.json #12694

fr0 opened this issue Oct 22, 2018 · 3 comments

Comments

@fr0
Copy link

fr0 commented Oct 22, 2018

Bug Report or Feature Request (mark with an x)

- [x] bug report -> please search issues before submitting
- [ ] feature request

Command (mark with an x)

- [ ] new
- [ ] build
- [ ] serve
- [ ] test
- [ ] e2e
- [ ] generate
- [ ] add
- [x] update
- [ ] lint
- [ ] xi18n
- [ ] run
- [ ] config
- [ ] help
- [ ] version
- [ ] doc

Versions

Angular CLI: 7.0.2
Node: 8.9.4
OS: darwin x64
Angular: 7.0.0
... animations, common, compiler, compiler-cli, core, elements
... forms, http, language-service, platform-browser
... platform-browser-dynamic, router

Package                           Version
-----------------------------------------------------------
@angular-devkit/architect         0.10.2
@angular-devkit/build-angular     0.10.2
@angular-devkit/build-optimizer   0.10.2
@angular-devkit/build-webpack     0.10.2
@angular-devkit/core              7.0.2
@angular-devkit/schematics        7.0.2
@angular/cli                      7.0.2
@ngtools/json-schema              1.1.0
@ngtools/webpack                  7.0.2
@schematics/angular               7.0.2
@schematics/update                0.10.2
ng-packagr                        4.4.0
rxjs                              6.3.3
typescript                        3.1.3
webpack                           4.19.1

Repro steps

I have a package.json that includes some private modules that are not on the global npm registry.
I include them via http, e.g.:

"dependencies": {
    "atlas-client-web": "http://some-url/atlas-client-web-v1.0.1.tgz",
   ...
}

The log given by the failure

Running command:

ng update @angular/cli @angular/core

Gives error:

Not found : atlas-client-web

This module does exist in the node_modules directory, so the error is unfounded.

Desired functionality

ng update should work with all types of module specs in package.json.

@alan-agius4
Copy link
Collaborator

alan-agius4 commented Oct 22, 2018

Relates to
#12632

@alan-agius4
Copy link
Collaborator

Fixed by #12526 as is available in the v7.1.0-beta.1

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants