-
Notifications
You must be signed in to change notification settings - Fork 12k
"ng update" doesn't support private repos such as FontAwesome 5 Pro #10624
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Okay, so I'm not the only one with the problem #10571 |
This should be fixed sooner than later |
There is definitely a problem when using a private npm repository. I could only run |
Can you provide the list of option names used within |
I have the same problem, my
|
Sure, this is what my
|
Hi @bjornharvold, @DaSchTour, Could you verify this is still an issue with 6.0.1? There were a few fixes regarding the registry flag (we have 1 fix in queue for the strict-ssl flag). Thanks! |
Yep still happens with 6.0.1. Targeting VSTS in my .npmrc registry=https://PRIVATE.pkgs.visualstudio.com/_packaging/PRIVATE/npm/registry/
|
Still valid for me too using a scoped repository.
Went smoothly but |
Experiencing this issue with Content of
|
Having the same issue using a JFrog Artifactory (universal artifact manager) as registry in |
I'm also having this same problem with @angular/[email protected] and VSTS |
Same problem here behind a private Nexus repo |
Same here, happens with our own private repo |
Same problem with 6.0.7 just now. |
@hansl any update on this? The issue still carries the "need: more info" label. |
I'm also curious, is there anything we can do or provide to speed this issue up? |
I think it is fixed by angular/devkit#982 in https://github.com/angular/devkit/releases/tag/v6.1.0-beta.1 release. Can anybody verify? |
I'd be happy to test it, but I'm not quite sure how to...I'm a little confused how devkit relates to CLI. What do I install to test this, is there an NPM package? Do I clone the repo and do an NPM link? If I install that package does the CLI use it, or does it supersede the CLI. Sorry, I'm a little ignorant, I'd love a little guidance. Or do I just wait for an updated @angular/cli v6.1.0-beta.1 to be released? |
@devoto13 I can't seem to find I was able to install |
I think this ticket can be closed. Why ? The original issue is that That issue is resolved. Other issues reported are
These two issues must be dealt with separately, IMHO. @Albyzai has not stated where the private repo is at. |
@catull probably it won't handle any other git repository right? Like gitlab/github/bitbucket/aws codecommit and many others... |
@alex88 Your repo URL ...
should it not be "my-package": "git+ssh://[email protected]:>>>>USERNAME/<<<<<<my-package.git#master" Compare this to my example: "@streamlabs/obs-studio-node": "git+ssh://[email protected]:>>>>>>computerquip/<<<<<<obs-studio-node#staging", |
@catull yes it's actually username/repo, I just wanted to remove also that part, sorry for the confusion |
No worries, just wanted to exclude another explanation .... |
@alex88 Have you considered using scoped package naming [1] ? See, this is a snippet of my .npmrc: @XXXXXXXXXX:registry=https://artifactory.YYYYYYYYYY:443/artifactory/api/npm/npm-virtual/
@fortawesome:registry=https://npm.fontawesome.com/
//npm.fontawesome.com/:_authToken=${NPM_TOKEN_FONTAWESOME} You could have "my-package": "git+ssh://[email protected]:@YOUR_SCOPE/my-package.git#master" As long as the package is published with @YOUR_SCOPE - could be @YOUR_ORGANISATION. It works for FontAwesome. Side note: You and I both know that "forte" in colloquial Italian means "awesome" in colloquial American English; my eye reads it as "awesome awesome" -> Super-awesome! FontAwesome's repository is not the canonical from npmjs.org Buona fortuna! |
Perhaps you are right. Assuming the http proxy config works for, say, the initial However, it is a different case from the original posting. I suggest you open a new issue with exactly the the title " |
@catull haha for the side note 🤣 Anyway, that would involve having our own registry or paying for a private hosted on if I understand it correctly, I think that for now I'll just remove that dependency, upgrade to angular 7 and add it back 😄 Hate to do that but having our own means more maintenance/resources and the other option would be adding another cost. You probably also know how much Italian companies can be stingy 😄 Btw, thanks for the option, if it's something we need to support in long term that's definitely an option to look for! |
On the scoped naming, the cost you incur is operating an NPM registry. See open source alternatives below, "verdaccio" [1] and "bitsrc.io" [2]. Imagine this. Let's just assume for a moment I like a certain library/package. Let's say it is called So, one day I decide to considerably change it, but the original maintainer is Now in this case, Given the fact that I like But I will be able to publish it say, as https://www.npmjs.com/package/@catull/banana. But let's also assume my company operates an internal NPM repository at registry.my-company.net:8080/npm/. Now I can publish it at https://registry.my-company.net:8080/npm/@SOME_SCOPE/banana You have to publish it with But here is the beauty: the scope name can be specifically configured in You can see a good example with bootstrap-vue:
|
@catull thanks a lot for the long explanation, I'll keep in mind, surely it's better than fetching from git directly 😄 |
@catull thank you, originally i had the same issue as the topic here and this is indeed now resolved. I'll open another issue as suggested, btw. yarn commands work, just the ng update doesnt. I tried migrate only - which works - and then update the packages via yarn, also works. I just think that I might miss something that ng update does as well, other than migrating to the angular.json file and lifting the packages to the recent version. ciao |
I really wonder why fontawesome pro works with 7.1.0 but fails with 7.1.1 and 7.1.2 |
I've same problem. "ng update --all" doesn't works with 7.1.2 (and 7.1.0 also) with private registry configured into local ".npmrc". @angular/cli while try to found package on registry.npmjs.org: 404 Not Found - GET https://registry.npmjs.org/mypackage - Not found But into .npmrc i've : |
@Chklang did you try with |
@aguacongas that works for me! |
@kpaxton You're lucky, that doesn't for me. But my private repo needs authentication. |
I also not lucky. I have also authentication set for my private registry and I am getting below error
|
Do you know what does |
In our npmrc we have options like strict-ssl and always-auth which are boolean values when being parsed. The update script in npm.ts tries to call 'replace' on the options and fails when the function does not exist (which it doesn't for bools): Now, ng update works as expected also with our private Artifactory |
Hi, I had the same problem, because we are using Artifactory in our company. We store private repositories in it. So I had the same error when trying to use ng update. But I can pass the parameter "-f" to force the update. I changed the names to give you an example what will happen with the force flag:
After that all was installed and update. I did this with the Angular and CDK package as well. We are updated the internal packages for our own. I hope this will help. |
PS: We also use https://www.npmjs.com/package/npm-check-updates with ncu command to check updates for our packages. This works well with Artifactory. So we now using ng update for all Angular related packages and ncu for other. But be careful and check if all new packages are working with the Angular packages. |
@florian-kittel |
Currently with |
This should now be addressed in 7.3.0+. If anyone is still encountering problems, please open a new issue detailing the issue. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Versions
Repro steps
Observed behavior
Mention any other details that might be useful (optional)
This works fine using npm directly because the private repo has already been registered with npm
The text was updated successfully, but these errors were encountered: