-
Notifications
You must be signed in to change notification settings - Fork 12k
Paths should follow the styleguide #316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
We should put off merging this this PR until the official style guide is in. Otherwise users will have no idea nor guidance as to how the structure is meant to be used. |
That is the official styleguide though. The document is going to adhere to this, not the other way around. |
The repo is not a document. We can't direct users to the repo for insights on style guide issues. We need a document that users can read and understand before we change the CLI to use it. |
At the current state of the project (pre-alpha) I think we can make changes without documentation in place. Especially given our milestone goals. |
Hi @hansl. Would you have a link to the repo mentioned? |
Adds a directory layer in preparation for following the style guide in the blueprints Updates to templates, tests and build process Related to angular#316
Adds a directory layer in preparation for following the style guide in the blueprints Updates to templates, tests and build process Related to angular#316
Adds a directory layer in preparation for following the style guide in the blueprints Updates to templates, tests and build process Related to angular#316
Adds a directory layer in preparation for following the style guide in the blueprints Updates to templates, tests and build process Related to angular#316
…nents/directives/pipes/services This is a step in aligning with the style guide and will provide the flexibility needed Related to angular#316
…nents/directives/pipes/services This is a step in aligning with the style guide and will provide the flexibility needed Related to angular#316
Implements the majority of style guide angular#316 Moves systemjs configuration our of index.html angular#429
Implements the majority of style guide angular#316 Moves systemjs configuration our of index.html angular#429
Implements the majority of style guide angular#316 Moves systemjs configuration our of index.html angular#429
Implements the majority of style guide angular#316 Moves systemjs configuration our of index.html angular#429
Implements the majority of style guide angular#316 Moves systemjs configuration our of index.html angular#429
Implements the majority of style guide angular#316 Moves systemjs configuration our of index.html angular#429
Implements the majority of style guide angular#316 Moves systemjs configuration our of index.html angular#429
Implements the majority of style guide angular#316 Moves systemjs configuration our of index.html angular#429
Implements the majority of style guide angular#316 Moves systemjs configuration our of index.html angular#429
Fixed via #427 |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Following the Houston app demo;
_
directory inside the routeThe following commands need to be changes (feel free to check those that are solved):
new
: simply a matter of updating the scaffold.generate
:component
/service
/pipe
: need to be added to an_
directory in the route specified. For example,ng generate component foo/bar/blah
should be generated in the directoryfoo/bar/_/blah
. If the_
is included then we don't need to add it (an_
route would be invalid here).route
: the scaffold need to include an empty_
directory under the route itself.index.ts
file to all scaffolds that export the component/route/service/pipe of that directory.I think that's it for this.
The text was updated successfully, but these errors were encountered: