Skip to content

Paths should follow the styleguide #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
6 tasks
hansl opened this issue Mar 18, 2016 · 7 comments
Closed
6 tasks

Paths should follow the styleguide #316

hansl opened this issue Mar 18, 2016 · 7 comments

Comments

@hansl
Copy link
Contributor

hansl commented Mar 18, 2016

Following the Houston app demo;

  • The directory structure need to be only including routes (not components, services or pipes). Components, services and pipes need to be in an _ directory inside the route
    The following commands need to be changes (feel free to check those that are solved):
    • new: simply a matter of updating the scaffold.
    • generate:
      • component/service/pipe: need to be added to an _ directory in the route specified. For example, ng generate component foo/bar/blah should be generated in the directory foo/bar/_/blah. If the _ is included then we don't need to add it (an _ route would be invalid here).
      • route: the scaffold need to include an empty _ directory under the route itself.
  • Adding an index.ts file to all scaffolds that export the component/route/service/pipe of that directory.

I think that's it for this.

@hansl hansl added this to the alpha.0 milestone Mar 18, 2016
@filipesilva
Copy link
Contributor

We should put off merging this this PR until the official style guide is in. Otherwise users will have no idea nor guidance as to how the structure is meant to be used.

@hansl
Copy link
Contributor Author

hansl commented Mar 18, 2016

That is the official styleguide though. The document is going to adhere to this, not the other way around.

@filipesilva
Copy link
Contributor

The repo is not a document. We can't direct users to the repo for insights on style guide issues.

We need a document that users can read and understand before we change the CLI to use it.

@Brocco
Copy link
Contributor

Brocco commented Mar 18, 2016

At the current state of the project (pre-alpha) I think we can make changes without documentation in place. Especially given our milestone goals.

@mattcarp
Copy link

Hi @hansl. Would you have a link to the repo mentioned?

Brocco added a commit to Brocco/angular-cli that referenced this issue Mar 31, 2016
Adds a directory layer in preparation for following the style guide in the blueprints
Updates to templates, tests and build process
Related to angular#316
Brocco added a commit to Brocco/angular-cli that referenced this issue Mar 31, 2016
Adds a directory layer in preparation for following the style guide in the blueprints
Updates to templates, tests and build process
Related to angular#316
Brocco added a commit to Brocco/angular-cli that referenced this issue Apr 5, 2016
Adds a directory layer in preparation for following the style guide in the blueprints
Updates to templates, tests and build process
Related to angular#316
Brocco added a commit to Brocco/angular-cli that referenced this issue Apr 5, 2016
Adds a directory layer in preparation for following the style guide in the blueprints
Updates to templates, tests and build process
Related to angular#316
Brocco added a commit to Brocco/angular-cli that referenced this issue Apr 7, 2016
…nents/directives/pipes/services

This is a step in aligning with the style guide and will provide the flexibility needed
Related to angular#316
Brocco added a commit to Brocco/angular-cli that referenced this issue Apr 7, 2016
…nents/directives/pipes/services

This is a step in aligning with the style guide and will provide the flexibility needed
Related to angular#316
Brocco added a commit that referenced this issue Apr 7, 2016
…nents/directives/pipes/services

This is a step in aligning with the style guide and will provide the flexibility needed
Related to #316
Closes #401
Brocco added a commit to Brocco/angular-cli that referenced this issue Apr 16, 2016
Implements the majority of style guide angular#316
Moves systemjs configuration our of index.html angular#429
Brocco added a commit to Brocco/angular-cli that referenced this issue Apr 16, 2016
Implements the majority of style guide angular#316
Moves systemjs configuration our of index.html angular#429
Brocco added a commit to Brocco/angular-cli that referenced this issue Apr 16, 2016
Implements the majority of style guide angular#316
Moves systemjs configuration our of index.html angular#429
Brocco added a commit to Brocco/angular-cli that referenced this issue Apr 16, 2016
Implements the majority of style guide angular#316
Moves systemjs configuration our of index.html angular#429
Brocco added a commit to Brocco/angular-cli that referenced this issue Apr 16, 2016
Implements the majority of style guide angular#316
Moves systemjs configuration our of index.html angular#429
Brocco added a commit to Brocco/angular-cli that referenced this issue Apr 16, 2016
Implements the majority of style guide angular#316
Moves systemjs configuration our of index.html angular#429
Brocco added a commit to Brocco/angular-cli that referenced this issue Apr 18, 2016
Implements the majority of style guide angular#316
Moves systemjs configuration our of index.html angular#429
Brocco added a commit to Brocco/angular-cli that referenced this issue Apr 18, 2016
Implements the majority of style guide angular#316
Moves systemjs configuration our of index.html angular#429
Brocco added a commit to Brocco/angular-cli that referenced this issue Apr 18, 2016
Implements the majority of style guide angular#316
Moves systemjs configuration our of index.html angular#429
Brocco added a commit that referenced this issue Apr 18, 2016
Implements the majority of style guide #316
Moves systemjs configuration our of index.html #429
Closes #427
@Brocco
Copy link
Contributor

Brocco commented Apr 18, 2016

Fixed via #427

@Brocco Brocco closed this as completed Apr 18, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants