Skip to content

chore: generation paths are fully dynamic & supports --flat for compo… #401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

Brocco
Copy link
Contributor

@Brocco Brocco commented Apr 7, 2016

…nents/directives/pipes/services

This is a step in aligning with the style guide and will provide the flexibility needed
Related to #316

…nents/directives/pipes/services

This is a step in aligning with the style guide and will provide the flexibility needed
Related to angular#316
@Brocco Brocco force-pushed the really-dynamic-paths branch from f602be4 to 2056b13 Compare April 7, 2016 11:42
@filipesilva
Copy link
Contributor

Nice!

locals: function (options) {
return generateLocals.call(this, options);
normalizeEntityName: function () {
var parsedPath = dynamicPathParser(this.project, 'ignore');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the entity name here supposed to be ignore?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no dynamically named items in this blueprint, so I just needed some text to pass in, route-config just generates a route-config.ts file

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah ok. I suppose that is being postponed until we have more info regarding the style guide, yes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, what I've been adding is to put the underlining support in to allow the blueprints to align with the style guide

@Brocco Brocco closed this in 5e9f462 Apr 7, 2016
@Brocco Brocco deleted the really-dynamic-paths branch April 19, 2016 01:37
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants