Skip to content

feat: adds client dir between src and app #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2016

Conversation

Brocco
Copy link
Contributor

@Brocco Brocco commented Mar 31, 2016

Adds a directory layer in preparation for following the style guide in the blueprints
Updates to templates, tests and build process
Related to #316

@hansl
Copy link
Contributor

hansl commented Mar 31, 2016

From appveyor:

√ ng generate component test\..\my-comp (313ms)
ERR:  { [Error: ENOENT: no such file or directory, uv_chdir] errno: -4058, code: 'ENOENT', syscall: 'uv_chdir' }

Legit?

@Brocco
Copy link
Contributor Author

Brocco commented Mar 31, 2016

Yes, AppVeyor failed because the full test run times out after an hour. The check mark means the test passed. I don't know how to rerun that test, thoughts?

@hansl
Copy link
Contributor

hansl commented Apr 1, 2016

Just restarted it.

@hansl
Copy link
Contributor

hansl commented Apr 1, 2016

Seems like everything is green. LGTM! Please rebase and submit.

Adds a directory layer in preparation for following the style guide in the blueprints
Updates to templates, tests and build process
Related to angular#316
@Brocco Brocco force-pushed the styleguide-paths branch from 7b55886 to a5ddd75 Compare April 5, 2016 03:37
@filipesilva
Copy link
Contributor

Ran npm test manually, since appveyor got stuck.

78 passing (5m)

@filipesilva filipesilva merged commit a5ddd75 into angular:master Apr 5, 2016
@Brocco Brocco deleted the styleguide-paths branch April 5, 2016 15:23
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants