Skip to content

Warning not displayed for resourcesOutputPath in esbuild. #25658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
1 task
wartab opened this issue Aug 10, 2023 · 2 comments · Fixed by #25659
Closed
1 task

Warning not displayed for resourcesOutputPath in esbuild. #25658

wartab opened this issue Aug 10, 2023 · 2 comments · Fixed by #25659

Comments

@wartab
Copy link

wartab commented Aug 10, 2023

Command

build, serve

Is this a regression?

  • Yes, this behavior used to work in the previous version

The previous version in which this bug was not present was

No response

Description

The following pull request added a check for resourcesOutputPath in angular_devkit/build_angular/src/builders/browser-esbuild/builder-status-warnings.ts. However, the variable unsupportedOption can never have that value, because the array which is iterated over doesn't contain that value.

#25495

I'm not sure if this is intentional, but I figured I'd point it out.

Minimal Reproduction

Irrelevant

Exception or Error

No response

Your Environment

Angular CLI: 16.2.0
Node: 18.16.0
Package Manager: npm 9.6.4
OS: win32 x64

Angular: 16.2.0
... animations, cdk, cli, common, compiler, compiler-cli, core
... forms, language-service, localize, material
... platform-browser, platform-browser-dynamic, router

Package                         Version
---------------------------------------------------------
@angular-devkit/architect       0.1602.0
@angular-devkit/build-angular   16.2.0
@angular-devkit/core            16.2.0
@angular-devkit/schematics      16.2.0
@schematics/angular             16.2.0
rxjs                            7.8.1
typescript                      5.1.6
zone.js                         0.13.1

Anything else relevant?

No response

@alan-agius4 alan-agius4 self-assigned this Aug 10, 2023
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Aug 10, 2023
…rcesOutputPath` with esbuilder

`resourcesOutputPath` option is not supported when using the esbuild based builder.

Closes angular#25658
alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Aug 10, 2023
…rcesOutputPath` with esbuild builder

`resourcesOutputPath` option is not supported when using the esbuild based builder.

Closes angular#25658
@wartab
Copy link
Author

wartab commented Aug 10, 2023

That was fast :O

alan-agius4 added a commit to alan-agius4/angular-cli that referenced this issue Aug 10, 2023
…rcesOutputPath` with esbuild builder

`resourcesOutputPath` option is not supported when using the esbuild based builder.

Closes angular#25658
dgp1130 pushed a commit that referenced this issue Aug 10, 2023
…rcesOutputPath` with esbuild builder

`resourcesOutputPath` option is not supported when using the esbuild based builder.

Closes #25658
dgp1130 pushed a commit to dgp1130/angular-cli that referenced this issue Aug 10, 2023
…rcesOutputPath` with esbuild builder

`resourcesOutputPath` option is not supported when using the esbuild based builder.

Closes angular#25658

(cherry picked from commit 4935172)
dgp1130 pushed a commit that referenced this issue Aug 10, 2023
…rcesOutputPath` with esbuild builder

`resourcesOutputPath` option is not supported when using the esbuild based builder.

Closes #25658

(cherry picked from commit 4935172)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants