Skip to content

fix(@angular-devkit/build-angular): display warning when using resourcesOutputPath with esbuild builder #25659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

alan-agius4
Copy link
Collaborator

resourcesOutputPath option is not supported when using the esbuild based builder.

Closes #25658

@alan-agius4 alan-agius4 added action: review The PR is still awaiting reviews from at least one requested reviewer target: patch This PR is targeted for the next patch release labels Aug 10, 2023
@alan-agius4 alan-agius4 requested a review from clydin August 10, 2023 08:12
@alan-agius4 alan-agius4 changed the title fix(@angular-devkit/build-angular): display warning when using resourcesOutputPath with esbuilder fix(@angular-devkit/build-angular): display warning when using resourcesOutputPath with esbuild builder Aug 10, 2023
@alan-agius4 alan-agius4 force-pushed the resourcesOutputPath-warning branch from ef94fa6 to 05fe63d Compare August 10, 2023 08:13
…rcesOutputPath` with esbuild builder

`resourcesOutputPath` option is not supported when using the esbuild based builder.

Closes angular#25658
@alan-agius4 alan-agius4 force-pushed the resourcesOutputPath-warning branch from 05fe63d to cfc2539 Compare August 10, 2023 08:20
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Aug 10, 2023
@dgp1130 dgp1130 merged commit 4935172 into angular:main Aug 10, 2023
@dgp1130
Copy link
Collaborator

dgp1130 commented Aug 10, 2023

ng-dev failed to merge this to patch. I made #25665 to handle that directly.

@alan-agius4 alan-agius4 deleted the resourcesOutputPath-warning branch August 11, 2023 03:51
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning not displayed for resourcesOutputPath in esbuild.
3 participants