Skip to content

refactor(@angular-devkit/build-angular): remove resourcesOutputPath option from application builder. #25495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

alan-agius4
Copy link
Collaborator

This resourcesOutputPath option is removed from the application builder. Instead the CSS resources will always be emitted in a directory named media. This is preparation to output server and browser bundles in different directories.

@alan-agius4 alan-agius4 force-pushed the remove-resourcesOutputPath-from-esbuild branch from 40b1b91 to 254ac7b Compare July 6, 2023 08:49
@alan-agius4 alan-agius4 added the target: minor This PR is targeted for the next minor release label Jul 6, 2023
@alan-agius4 alan-agius4 force-pushed the remove-resourcesOutputPath-from-esbuild branch from 254ac7b to a6947c4 Compare July 6, 2023 08:49
… option from application builder.

This `resourcesOutputPath` option is removed from the application builder. Instead the CSS resources will always be emitted in a directory named `media`. This is preparation to output server and browser bundles in different directories.
@alan-agius4 alan-agius4 force-pushed the remove-resourcesOutputPath-from-esbuild branch from a6947c4 to 1a5dcdb Compare July 6, 2023 10:07
@alan-agius4 alan-agius4 added the action: review The PR is still awaiting reviews from at least one requested reviewer label Jul 6, 2023
@alan-agius4 alan-agius4 requested a review from clydin July 6, 2023 12:57
@alan-agius4 alan-agius4 marked this pull request as ready for review July 6, 2023 12:57
@alan-agius4 alan-agius4 added action: merge The PR is ready for merge by the caretaker and removed action: review The PR is still awaiting reviews from at least one requested reviewer labels Jul 6, 2023
@dgp1130 dgp1130 merged commit 3bb48c1 into angular:main Jul 6, 2023
@alan-agius4 alan-agius4 deleted the remove-resourcesOutputPath-from-esbuild branch July 6, 2023 16:37
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker target: minor This PR is targeted for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants