-
Notifications
You must be signed in to change notification settings - Fork 12k
Multi-locale Ivy builds do not use registerLocaleData #15974
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Milestone
Comments
filipesilva
added a commit
to filipesilva/angular-cli
that referenced
this issue
Oct 30, 2019
…multiple locales Related to angular#15974
filipesilva
added a commit
to filipesilva/angular-cli
that referenced
this issue
Oct 30, 2019
…multiple locales Related to angular#15974
filipesilva
added a commit
to filipesilva/angular-cli
that referenced
this issue
Oct 30, 2019
…multiple locales Related to angular#15974
filipesilva
added a commit
to filipesilva/angular-cli
that referenced
this issue
Oct 30, 2019
…multiple locales Related to angular#15974
filipesilva
added a commit
to filipesilva/angular-cli
that referenced
this issue
Oct 30, 2019
…multiple locales Related to angular#15974
clydin
pushed a commit
to filipesilva/angular-cli
that referenced
this issue
Oct 30, 2019
…multiple locales Related to angular#15974
clydin
pushed a commit
to filipesilva/angular-cli
that referenced
this issue
Oct 30, 2019
…multiple locales Related to angular#15974
clydin
pushed a commit
to filipesilva/angular-cli
that referenced
this issue
Oct 30, 2019
…multiple locales Related to angular#15974
clydin
pushed a commit
to filipesilva/angular-cli
that referenced
this issue
Oct 30, 2019
…multiple locales Related to angular#15974
clydin
pushed a commit
to filipesilva/angular-cli
that referenced
this issue
Oct 30, 2019
…multiple locales Related to angular#15974
vikerman
pushed a commit
that referenced
this issue
Oct 30, 2019
…multiple locales Related to #15974
@vikerman this is still open. The PR was related to this issue but does not fix it. |
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
localeData
, obtained via@angular/common/locales/<locale>
, is needed for several FW features like pluralization.In VE each build resulted in a single locale. To register the locale data in VE the CLI added the following code via a transform:
Locales can also have extra information that the CLI did not handle. It would have required to use add the code below instead:
In Ivy each build can result in several locales. To use a similar mechanism would look like this:
This approach is not ideal because all locale-specific builds would include all locale data.
Since localize operates after code is built and bundled, introducing locale specific data presents a novel problem.
A repro of this problem can be found in https://github.com/filipesilva/i18n. It is still possible to do individual locale builds (via the
i18n*
options) with Ivy though.The text was updated successfully, but these errors were encountered: