Skip to content

Re-enable global locale data support for Ivy #16196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 15, 2019
Merged

Re-enable global locale data support for Ivy #16196

merged 3 commits into from
Nov 15, 2019

Conversation

clydin
Copy link
Member

@clydin clydin commented Nov 14, 2019

This also adds global local data support to the development server.

@clydin clydin added the target: patch This PR is targeted for the next patch release label Nov 14, 2019
@clydin clydin force-pushed the revert-global-locales-disable branch from 82e53c3 to 337c8e1 Compare November 14, 2019 17:37
@clydin clydin requested a review from filipesilva November 14, 2019 18:05
filipesilva
filipesilva approved these changes Nov 14, 2019
View reviewed changes
Copy link
Contributor

@filipesilva filipesilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hooray! 🎉

@dgp1130 dgp1130 merged commit 04cb2ac into angular:master Nov 15, 2019
@dgp1130
Copy link
Collaborator

dgp1130 commented Nov 15, 2019

Merged to 9.0.x patch branch: https://github.com/angular/angular-cli/commits/9.0.x.

@clydin clydin deleted the revert-global-locales-disable branch November 15, 2019 18:55
@clydin clydin mentioned this pull request Nov 25, 2019
Closed
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@petebacondarwin petebacondarwin petebacondarwin approved these changes

@filipesilva filipesilva filipesilva approved these changes

Assignees
No one assigned
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@clydin @dgp1130 @petebacondarwin @filipesilva @googlebot