Skip to content

fix(@angular-devkit/build-angular): insert locale data when localizing #15989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 7, 2019

Conversation

clydin
Copy link
Member

@clydin clydin commented Oct 31, 2019

Since the deprecated locale data registration was removed, existing tests that rely on locale data will fail if these changes do not properly inject the new form of the locale data.

@clydin clydin added the target: major This PR is targeted for the next major release label Oct 31, 2019
@clydin clydin force-pushed the preprend-locale-data branch 2 times, most recently from 7c20c26 to ca48fd6 Compare November 4, 2019 20:54
@clydin clydin force-pushed the preprend-locale-data branch 5 times, most recently from f096f8f to 3107f21 Compare November 6, 2019 18:45
@clydin clydin marked this pull request as ready for review November 6, 2019 18:46
@clydin clydin force-pushed the preprend-locale-data branch 2 times, most recently from c0bf0c2 to 733e7de Compare November 6, 2019 23:09
@clydin clydin force-pushed the preprend-locale-data branch from 733e7de to 3c83530 Compare November 6, 2019 23:58
@vikerman vikerman added target: patch This PR is targeted for the next patch release and removed target: major This PR is targeted for the next major release labels Nov 7, 2019
@vikerman vikerman merged commit 1941762 into angular:master Nov 7, 2019
@clydin clydin deleted the preprend-locale-data branch November 7, 2019 18:54
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Dec 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants