Skip to content

Add experimentalImportFactories when migrating to loadChildren import syntax #14218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
filipesilva opened this issue Apr 19, 2019 · 4 comments · Fixed by #14231
Closed

Add experimentalImportFactories when migrating to loadChildren import syntax #14218

filipesilva opened this issue Apr 19, 2019 · 4 comments · Fixed by #14231

Comments

@filipesilva
Copy link
Contributor

filipesilva commented Apr 19, 2019

The #14181 migration also needs to add "experimentalImportFactories": true to angular.json (#13948) to make the import syntax supported in VE.

The tsconfig file should also be updated to use "module": "esnext", and a e2e test should be added to test the update works and an app with lazy routes will be updated and runs properly.

@filipesilva filipesilva added this to the 8.0 milestone Apr 19, 2019
@ngbot ngbot bot modified the milestone: 8.0 Apr 19, 2019
@filipesilva filipesilva added this to the 8.0 milestone Apr 19, 2019
@ngbot ngbot bot modified the milestones: 8.0, Backlog Apr 19, 2019
@filipesilva filipesilva modified the milestones: Backlog, 8.0 Apr 19, 2019
@filipesilva
Copy link
Contributor Author

Part of this is done in #14222

@alexeagle
Copy link
Contributor

We should add this in the same migration with fix-lazy-routes so if we drop that feature from RC, we also drop the addition of this "experimental" flag

filipesilva added a commit to filipesilva/angular-cli that referenced this issue Apr 22, 2019
…es option

It will just be always be used when applicable.

Fix angular#14218
@alexeagle
Copy link
Contributor

Don't need this one if we do #14231

alexeagle pushed a commit that referenced this issue Apr 22, 2019
…es option

It will just be always be used when applicable.

Fix #14218
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants