Skip to content

Remove experimentalImportFactories #14231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

filipesilva
Copy link
Contributor

@filipesilva filipesilva commented Apr 22, 2019

It will just be always be used when applicable.

Fix #14218

…es option

It will just be always be used when applicable.

Fix angular#14218
It will just be always be used when applicable.
@filipesilva filipesilva requested a review from alexeagle April 22, 2019 16:12
@filipesilva filipesilva added the target: major This PR is targeted for the next major release label Apr 22, 2019
@alexeagle
Copy link
Contributor

Discussed with Igor - we agree with removing the flag for RC0 and always enable. Then if we decide that fix-lazy-routes can't stay in RC we'll have to re-introduce this.

@alexeagle alexeagle merged commit c8d9e54 into angular:master Apr 22, 2019
@filipesilva filipesilva deleted the remove-experimentalImportFactories branch April 23, 2019 07:37
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
target: major This PR is targeted for the next major release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add experimentalImportFactories when migrating to loadChildren import syntax
3 participants