Skip to content

test: add 7.0 update test #14228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2019
Merged

test: add 7.0 update test #14228

merged 1 commit into from
Apr 24, 2019

Conversation

filipesilva
Copy link
Contributor

No description provided.

@filipesilva filipesilva force-pushed the lazy-route-migration-e2e branch from 3308457 to b55c362 Compare April 22, 2019 14:55
@filipesilva filipesilva mentioned this pull request Apr 22, 2019
Closed
@filipesilva filipesilva force-pushed the lazy-route-migration-e2e branch from b55c362 to 9168b24 Compare April 22, 2019 15:09
@filipesilva filipesilva force-pushed the lazy-route-migration-e2e branch from 9168b24 to e15fc82 Compare April 22, 2019 16:16
@filipesilva filipesilva mentioned this pull request Apr 22, 2019
Merged
@filipesilva filipesilva force-pushed the lazy-route-migration-e2e branch from e15fc82 to 45c5e14 Compare April 22, 2019 17:40
@filipesilva filipesilva force-pushed the lazy-route-migration-e2e branch from 45c5e14 to 822ce86 Compare April 22, 2019 17:48
filipesilva
filipesilva commented Apr 22, 2019
View reviewed changes
tests/legacy-cli/e2e/tests/basic/update-7.0.ts Outdated
`loadChildren: () => import('./lazy/lazy.module').then(m => m.LazyModule)`);
// Unnecessary es6 polyfills should be removed via drop-es6-polyfills.
await expectToFail(() => expectFileToMatch('src/polyfills.ts', `import 'core-js/es6/symbol';`));
await expectToFail(() => expectFileToMatch('src/polyfills.ts', `import 'core-js/es6/set';`));
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocked on #14234

@filipesilva filipesilva force-pushed the lazy-route-migration-e2e branch from 822ce86 to 69761dd Compare April 23, 2019 15:27
@filipesilva filipesilva force-pushed the lazy-route-migration-e2e branch 5 times, most recently from b960bbb to 7a5955c Compare April 23, 2019 22:32
@filipesilva filipesilva force-pushed the lazy-route-migration-e2e branch from 7a5955c to a8e33c1 Compare April 23, 2019 22:49
@filipesilva filipesilva added the target: major This PR is targeted for the next major release label Apr 24, 2019
@alexeagle alexeagle merged commit f53d5ec into angular:master Apr 24, 2019
@filipesilva filipesilva deleted the lazy-route-migration-e2e branch April 24, 2019 00:31
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 13, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alexeagle alexeagle alexeagle left review comments

@clydin clydin clydin approved these changes

@norawis norawis norawis approved these changes

Assignees
No one assigned
Labels
target: major This PR is targeted for the next major release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@filipesilva @alexeagle @clydin @norawis @googlebot