Skip to content

8 migration does not remove commented polyfills #14234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
filipesilva opened this issue Apr 22, 2019 · 2 comments
Closed

8 migration does not remove commented polyfills #14234

filipesilva opened this issue Apr 22, 2019 · 2 comments

Comments

@filipesilva
Copy link
Contributor

CLI 7 projects have almost all polyfills commented out except zone.js.

The CLI 8 migration attempts to remove polyfills imports by parsing the AST, but since they are commented out they never show up.

The migration should remove these imports regardless of being commented out, since they aren't necessary anymore.

@filipesilva
Copy link
Contributor Author

This should be ok now. We also check for known hashes of unmodified polyfills file, for both Linux and Windows, and replace those. That should cover most of the comment cases.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
@clydin clydin removed their assignment Jun 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants