Change $select.clear() so it sets value to null instead of undefined

[v-andrew]

Type: fix
Scope: uiSelectMatch

Fixes #863

[v-andrew]

PR does not add more failing test.
Same tests are failing in the master branch.

[Jefiozie]

So i tested your adjustments and local i'm getting the same result. Can you double check at your end.

Thanks.

[Jefiozie]

Hi @v-andrew I think i have found the reason for the failing unit tests. Waiting for some comments why things have changed after this we can probably rebase your PR and the unit test problem will be resolved.

Thanks.

[v-andrew]

@Jefiozie Thanks
I can rebase it myself, just let me know, when CI issue solved

[Jefiozie]

HI @v-andrew , I have merged my PR could you rebase to the master?
Thanks.

[cloudrick]

Hi @v-andrew

I have two questions:

1. If the repeat expression of ui-select-choices is like "<ui-select-choices repeat="o.name as o in XXX>",
   the ngModel's value will still be undefined even if we set null to ctrl.
   Maybe we need to modify ngModel.$parsers to skip handling for undefined and null
   Ex:

// From view --> model
ngModel.$parsers.unshift(function (inputValue) {
  // Keep original value for undefined and null
  if (inputValue === undefined || inputValue === null) {
    return inputValue;
  }
  ......
});

2. In ctrl.select(), does it need to handle null value as undefined value?
   Ex:

  ctrl.select = function(item, skipFocusser, $event) {
    if (item === undefined || item === null || !_isItemDisabled(item)) {
    ......

Thanks

[v-andrew]

@Jefiozie sorry, for the delay, I'm quite busy.
Tests are passing now.

[v-andrew]

@cloudrick Let me look into it.

[Jefiozie]

Hi @v-andrew , any updates on this PR. Thanks.

[Jefiozie]

Any updates on this issue?

Thanks

[jrbotros]

Happy to take this over if you're too busy, @v-andrew!

[Jefiozie]

@v-andrew can @jrbotros have a look at this? based on your most recent updates you have not the time (at the moment) to finish this PR. Could @jrbotros take over?

@jrbotros can you have a look it?

[Jefiozie]

@jrbotros Can you have a look at it?

[jrbotros]

@Jefiozie @v-andrew Happy to take this over, will look to get it finished in the next day or two!

[jrbotros]

@Jefiozie just submitted #1959, let me know what you think!
@v-andrew thanks for getting this started 😊

[Jefiozie]

Closing this down as we are continuing on #1959