fix(uiSelectMatch): set model value to null when cleared
#1959
Conversation
| @@ -636,6 +639,31 @@ describe('ui-select tests', function () { | |||
| expect(el.find('.select2-search-choice-close').length).toEqual(1); | |||
| }); | |||
|
|
|||
| it('should clear selection (with object as source)', function() { | |||
There was a problem hiding this comment.
Could you maybe make use of createUISelect and /or createUIMultipleSelect function in the tests?
There was a problem hiding this comment.
The main should clear selection test above still uses createUISelect, but I didn't see a way to test the "object as source" syntax without compiling the template manually (I used the should bind model correctly (with object as source) test as a template). Any ideas how to make this cleaner?
There was a problem hiding this comment.
ah missed that yeah hmm.. maybe we could make a new function createUiSelectObjectSource or some other good name where the template is build and can be used in the future?
There was a problem hiding this comment.
Let's get this landed and open another issue for doing some test cleanup? Happy to take a stab at it in a few days (probably over the weekend)!
There was a problem hiding this comment.
Maybe it is best I want to do some major refactoring to this repo, for example it needs to have seperate directives for tagging etc.
Closes #863