This repository was archived by the owner on Oct 2, 2019. It is now read-only.
Change to set null instead of undefined when ctrl is clea #1918
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[why] Null is more readable for empty value.
[how] * When ctrl is cleared, set null to its selection.
* In ngModel.$parsers, add a handler to
) return null for null value.
) return undefined for undefined value.
* Also modify test case for checking clear value.
|
Closing it down as it is a duplicate of #1908, please comment on that PR if you see problems with the proposed solution. Thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[why] Null is more readable for empty value.
[how] * When ctrl is cleared, set null to its selection.
* In ngModel.$parsers, add a handler to
) return null for null value.
) return undefined for undefined value.
* Also modify test case for checking clear value.