Skip to content

fix($resolve): Resolves only inherit from immediate parent #1212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 27, 2014
Merged

fix($resolve): Resolves only inherit from immediate parent #1212

merged 1 commit into from
Aug 27, 2014

Conversation

asperry152
Copy link
Contributor

fixes #702

@pdeva
Copy link

pdeva commented Jul 19, 2014

as a side request, please increment the version number when you merge this PR so we can grab the latest version with this fixed.

@trueqbit
Copy link

Bugs me as well when transitioning from one grandchild to the other

@wawyed
Copy link
Contributor

wawyed commented Jul 28, 2014

When is this fix going to the merged, it's a really annoying bug.

@timkindberg
Copy link
Contributor

This looks good. @nateabele what do you think?

@christopherthielen
Copy link
Contributor

I think Nate said he was rewriting the resolve code in a private branch. I think we should wait until he pushes that branch.

@nateabele
Copy link
Contributor

Yeah I have this merged locally. @christopherthielen do you have time to chat tomorrow afternoon?

@christopherthielen
Copy link
Contributor

@nateabele This week is really full for me as I've been working 12-15 hour days. I should be freeing up significantly after Friday. I'm looking forward to see your changes though, since I have a few issues with the current resolve/locals setup.

christopherthielen added a commit that referenced this pull request Aug 27, 2014
fix($resolve): Resolves only inherit from immediate parent
@christopherthielen christopherthielen merged commit b92211d into angular-ui:master Aug 27, 2014
@christopherthielen christopherthielen added this to the 0.2.11 milestone Nov 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resolves only inherit from immediate parent
7 participants