Skip to content

inheriting resolvers with the same name over childs #1317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
darkyelox opened this issue Aug 31, 2014 · 6 comments · Fixed by #1360
Closed

inheriting resolvers with the same name over childs #1317

darkyelox opened this issue Aug 31, 2014 · 6 comments · Fixed by #1360
Labels
Milestone

Comments

@darkyelox
Copy link

I'm extending my resolvers objects using $.extend for adding some common code, one of them is adding a general resolver which is inherited and also defined by each child states, this works in version 0.2.10 but there is something weird in 0.2.11, because my child are inheriting the resolver one state up and is not using the own (this is happening in the controller of the state), i have this http://plnkr.co/edit/ewmHII?p=info plunker for see the issue, i'm using 0.2.10 for see the spected behavior, then i change to the last version (commenting and uncommenting) the problem can be seen in the console, in this example i'm emulating the use of a common resolver and printing the resolver in the state controller.

@christopherthielen
Copy link
Contributor

Hmmm... Likely related to #1212

Thanks for the detailed bug report.

@christopherthielen christopherthielen added this to the 0.2.12 milestone Aug 31, 2014
@darkyelox
Copy link
Author

i want to know, what i need to do its normal for this plugin? for now i switch to 0.2.10

@nateabele
Copy link
Contributor

@christopherthielen This case is already addressed by your rewrite, yeah?

@christopherthielen
Copy link
Contributor

I think the rewrite should address it, but I'll have to take a look at the plunkr to see exactly how the resolves are being inherited. Probably leave this open for now.

@baudetail
Copy link

Same Problem here ... I think this issue is not fixed now.

#1353

christopherthielen added a commit that referenced this issue Sep 12, 2014
…me name

Made resolve values ignore any keys that we're actively trying to
resolve, when they also exist in some parent state.  Made $$resolves
persist so they can be picked up by a child state in a later digest()
fixes #1317
fixes #1353
@christopherthielen
Copy link
Contributor

Fix coming in #1360
http://plnkr.co/edit/ku4Ovt?p=preview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants