-
Notifications
You must be signed in to change notification settings - Fork 3k
Resolves only inherit from immediate parent #702
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
BUG! This should definitely work. |
Thanks for the workaround. Also see #482. |
+1. this is a pretty major bug. |
+1 |
1 similar comment
+1 |
Is there any updates on this issue? It's really annoying having to redefine the resolve objects at every child state. |
ui-router project seems to be dead frankly. no commits for almost a month |
I really hope not since our app relies heavily on it and there isn't any really good alternative to it. |
+1 This bug has been a real headache. Here is a fork of ribizli's broken plunker with a patched version of ui-router that solves the error: http://plnkr.co/edit/mUqyPK?p=preview I will submit a pull request later today after adding some tests and hopefully get some feedback from the project owners. |
+1 |
Pull request made. @nateabele Can you review and give feedback regarding suitability of this code change please? |
+1 |
Looking good 👍 |
any plans for merging? |
I'll resubmit the pull request this evening with the correct comment. |
@timkindberg New pull request that I'm hoping you can now merge. |
…lar-ui#702 Signed-off-by: Nate Abele <[email protected]>
I've found a strange behaviour which might be an issue. See this plunker:
http://plnkr.co/edit/hPX3GE12wZkbGBKYCWwF
Resolve works when steping A -> B -> C, but if we go from A -> C directly, first we get 'Unknown provider: AProvider' and later 'Circular dependency found'.
A dirty solution for this is to re-resolve A in 'a.b' state again:
http://plnkr.co/edit/voANmxRXdSUXhMxqIC1z
Is this really a bug?
EDIT: Rename bug for clarity
The text was updated successfully, but these errors were encountered: