Skip to content

Resolves only inherit from immediate parent #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ribizli opened this issue Dec 19, 2013 · 16 comments · Fixed by #1212
Closed

Resolves only inherit from immediate parent #702

ribizli opened this issue Dec 19, 2013 · 16 comments · Fixed by #1212
Labels
Milestone

Comments

@ribizli
Copy link

ribizli commented Dec 19, 2013

I've found a strange behaviour which might be an issue. See this plunker:
http://plnkr.co/edit/hPX3GE12wZkbGBKYCWwF

Resolve works when steping A -> B -> C, but if we go from A -> C directly, first we get 'Unknown provider: AProvider' and later 'Circular dependency found'.

A dirty solution for this is to re-resolve A in 'a.b' state again:
http://plnkr.co/edit/voANmxRXdSUXhMxqIC1z

Is this really a bug?

EDIT: Rename bug for clarity

@timkindberg
Copy link
Contributor

BUG! This should definitely work.

@mntnoe
Copy link

mntnoe commented Jan 23, 2014

Thanks for the workaround. Also see #482.

@pdeva
Copy link

pdeva commented Jun 4, 2014

+1. this is a pretty major bug.

@toxicFork
Copy link

+1

1 similar comment
@masimplo
Copy link

masimplo commented Jun 5, 2014

+1

@wawyed
Copy link
Contributor

wawyed commented Jun 30, 2014

Is there any updates on this issue? It's really annoying having to redefine the resolve objects at every child state.

@pdeva
Copy link

pdeva commented Jun 30, 2014

ui-router project seems to be dead frankly. no commits for almost a month

@wawyed
Copy link
Contributor

wawyed commented Jun 30, 2014

I really hope not since our app relies heavily on it and there isn't any really good alternative to it.

@asperry152
Copy link
Contributor

+1 This bug has been a real headache.
@ribizli thanks for the workaround.

Here is a fork of ribizli's broken plunker with a patched version of ui-router that solves the error: http://plnkr.co/edit/mUqyPK?p=preview

I will submit a pull request later today after adding some tests and hopefully get some feedback from the project owners.

@alex6o
Copy link

alex6o commented Jul 2, 2014

+1

@asperry152
Copy link
Contributor

Pull request made.

@nateabele Can you review and give feedback regarding suitability of this code change please?

@wawyed
Copy link
Contributor

wawyed commented Jul 3, 2014

+1

@jketcham
Copy link

jketcham commented Jul 9, 2014

Looking good 👍

@alex6o
Copy link

alex6o commented Jul 18, 2014

any plans for merging?

@asperry152
Copy link
Contributor

I'll resubmit the pull request this evening with the correct comment.

@asperry152
Copy link
Contributor

@timkindberg New pull request that I'm hoping you can now merge.

nateabele pushed a commit to nateabele/ui-router that referenced this issue Aug 22, 2014
@christopherthielen christopherthielen modified the milestones: 0.2.11, 1.5.0 Nov 16, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.