refactor(model:user): exclude password info by default #1620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
Awk34
added a commit
that referenced
this pull request
Feb 9, 2016
refactor(model:user): exclude password info by default
|
Hmm, looks like the sequelize one isn't quite working. Have you tested it? I see this in the failed build: |
|
Also 1) User API: GET /api/users/me should respond with a user profile when authenticated:
Uncaught TypeError: Cannot read property 'toString' of undefined
at Test.<anonymous> (server/api/user/user.integration.js:53:23)
at Test.assert (/home/rof/src/github.com/angular-fullstack/generator-angular-fullstack/test/fixtures/node_modules/supertest/lib/test.js:156:6)
at Server.assert (/home/rof/src/github.com/angular-fullstack/generator-angular-fullstack/test/fixtures/node_modules/supertest/lib/test.js:127:12)
at emitCloseNT (net.js:1524:8) |
|
I have reverted this. If you can find a fix, feel free to submit another PR. |
| @@ -228,6 +229,12 @@ module.exports = function(sequelize, DataTypes) { | |||
| } else { | |||
| fn(null); | |||
| } | |||
| }, | |||
|
|
|||
| toJSON: function() { | |||
There was a problem hiding this comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
based on PR #1049 from @Awk34 commit (5fecaba).
Hi, this is another attempt at excluding the password info by default and not just at query time. The sequelize way of doing it is not pretty but seems to be the recommended way. And it does not look like there will be a different way anytime soon.