Skip to content

Make salt & password not selected by default #569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
thomporter opened this issue Sep 19, 2014 · 7 comments
Open

Make salt & password not selected by default #569

thomporter opened this issue Sep 19, 2014 · 7 comments
Assignees

Comments

@thomporter
Copy link

We should add select: false to the password fields (hashedPassword/password and salt.) Then go to the one place we need those fields and ask they be included in our query... I have done this manually on a couple projects I created with the generator and it's worked out nicely, I don't have to worry about adding -password -salt to user queries later...

I have been meaning to submit a PR about this, but I've been busy...

@JaKXz
Copy link
Collaborator

JaKXz commented Sep 25, 2014

@thomporter is this related to #231 at all?

@kingcody
Copy link
Member

@thomporter just wondering if you had a branch for this yet?

@guiltry
Copy link

guiltry commented Sep 28, 2014

I guess, they (he and #231) are talking about fullstack-demo.

  1. Excluding salt and hashedPassword on UserSchema definition in user.model.js:8.
  2. Including these fields on auth query in passport.js:10.
  3. So, you won't exclude these fields manually everytime you get a user, like in user.controller.js:89.

Doesn't it ?

@thomporter
Copy link
Author

@JaKXz Yup. I didn't see #231, or your reply...

@kingcody No sorry, I haven't had the time. Not sure I will this week either, just pulled in 2 big projects...

@guiltry has outlined the issue perfectly.

@guiltry
Copy link

guiltry commented Sep 28, 2014

Nice 😄

Btw, How do you generate demo project ?

@DaftMonk
Copy link
Member

@guiltry the demo is generated by running grunt demo from the generator-angular-fullstack folder

@Awk34
Copy link
Member

Awk34 commented Jul 9, 2015

#1049 #1620

@Awk34 Awk34 closed this as completed May 13, 2016
@Awk34 Awk34 reopened this May 13, 2016
@Awk34 Awk34 self-assigned this May 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants