Skip to content

refactor(model:user): exclude password info by default #1049

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

refactor(model:user): exclude password info by default #1049

wants to merge 1 commit into from

Conversation

Awk34
Copy link
Member

@Awk34 Awk34 commented Jul 9, 2015

thanks to guiltry for the original commit (89980c5)

@Awk34
refactor(model:user): exclude password info by default
5fecaba 
thanks to guiltry for the original commit (89980c5)
This was referenced Jul 9, 2015
Closed
Open
@Awk34 Awk34 added this to the 2.3.0 milestone Jul 15, 2015
@kingcody
Copy link
Member

Whats the status on this one?

@Awk34
Copy link
Member Author

Awk34 commented Jul 16, 2015

The tests fail, I haven't looked into fixing them yet

@kingcody
Copy link
Member

So without additional plugins, I'm not sure we can get this to work for sequelize. For now it may just need to be a mongoose feature.

@carragom carragom mentioned this pull request Feb 9, 2016
Merged
@Awk34 Awk34 closed this Feb 9, 2016
@Awk34 Awk34 deleted the refactor-user-model-password-hiding branch June 21, 2016 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement minor
Projects
None yet
Milestone
Soon
Development

Successfully merging this pull request may close these issues.
2 participants
@Awk34 @kingcody