-
Notifications
You must be signed in to change notification settings - Fork 35
fix buffer length var in socket_write() #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Build CI fail, but it's not my fixes. ************* Module wiznet5k_wsgiserver_test |
Ok, likely the version of PyLint has been updated on our CI and it's throwing errors due to new rules(@kattni - could you confirm this is what occurred?). Do you have cycles to fix these linter errors and commit to this branch? Otherwise, I can fix and commit to the branch as well. I'd like to merge this fix in - thank you for finding it - let me know what you want to do and we'll do it. |
@brentru I can't get the check failure to load when I click details, so I can't verify the list of failures. This library uses |
@brentru I don't think I can handle these linter errors..., I need you to handle this (including my fix) and close this PR. Thx :) |
# Conflicts: # examples/wiznet5k_wsgiserver_test.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I merged main and it got this passing CI.
Changes look good to me. Tested successfully simpletest and wsgiserver test using feather rp2040 and Ethernet featherwing.
Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM303_Accel to 1.1.9 from 1.1.8: > Merge pull request adafruit/Adafruit_CircuitPython_LSM303_Accel#13 from adafruit/dhalbert-ustruct > update rtd py version Updating https://github.com/adafruit/Adafruit_CircuitPython_SHT31D to 2.3.9 from 2.3.8: > Merge pull request adafruit/Adafruit_CircuitPython_SHT31D#27 from KeithTheEE/crc_fix Updating https://github.com/adafruit/Adafruit_CircuitPython_Touchscreen to 1.1.9 from 1.1.8: > Merge pull request adafruit/Adafruit_CircuitPython_Touchscreen#19 from CedarGroveStudios/main Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 1.11.2 from 1.11.1: > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#42 from bjnhur/master > update rtd py version Updating https://github.com/adafruit/Adafruit_CircuitPython_PIOASM to 0.5.2 from 0.5.1: > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#32 from dannystaple/patch-1
Related to Issue #41
Fix buf length logic in socket_write() on adafruit_wiznet5k/adafruit_wiznet5k.py
Would you pls check this commit @brentru ?