CRC Mismatch fix #27
Merged
CRC Mismatch fix #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the datasheet and the other crc code from Sensirion. It is 0x131 in the original code from Sensirion, however their docs and github now use a helper library which uses 0x31. 0x31 is Probably the correct polynomial.
ladyada
approved these changes
Dec 29, 2021
|
seems ok! did not test |
|
Thx! fixed. The problem was not enough current. |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jan 4, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM303_Accel to 1.1.9 from 1.1.8: > Merge pull request adafruit/Adafruit_CircuitPython_LSM303_Accel#13 from adafruit/dhalbert-ustruct > update rtd py version Updating https://github.com/adafruit/Adafruit_CircuitPython_SHT31D to 2.3.9 from 2.3.8: > Merge pull request adafruit/Adafruit_CircuitPython_SHT31D#27 from KeithTheEE/crc_fix Updating https://github.com/adafruit/Adafruit_CircuitPython_Touchscreen to 1.1.9 from 1.1.8: > Merge pull request adafruit/Adafruit_CircuitPython_Touchscreen#19 from CedarGroveStudios/main Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 1.11.2 from 1.11.1: > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#42 from bjnhur/master > update rtd py version Updating https://github.com/adafruit/Adafruit_CircuitPython_PIOASM to 0.5.2 from 0.5.1: > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#32 from dannystaple/patch-1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This needs to be tested on hardware, but it should fix #26
There are two changes: CRC's returned value is now anded with
0xFFto ensure it's one byte only.The second change is from the CRC Polynomial, which was
0x131and is now0x31. The datasheet and other Sensirion sensors all use0x31, however if you go through the Sensirion download center to download sample c++ code, the sample code uses0x131. Given the Sensirion github is more likely to be up to date, and given they now use a helper library for the CRC which sets the polynomial to0x31I think0x31is the correct option.But because that's a large enough change, I need that to be tested to be sure it fixes #26