Skip to content

Add helpful wrappers for errors #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 2, 2022
Merged

Conversation

dannystaple
Copy link
Contributor

These wrappers make errors a bit more descriptive than "not in sequence".

Copy link
Contributor

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good. One minor piece of advice for the future.

@@ -16,3 +16,4 @@ bundles
dist
**/*.egg-info
.vscode
.venv
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I always push back gently about additions like this to gitignore files.

If you commonly create ".venv" in projects where you work, it's better if you use your own global gitignore file, because it'll allow git to ignore ".venv" in any project on your system, without modifying the project gitignore file.

Here's a quick read that shows how to set it up: https://sebastiandedeyne.com/setting-up-a-global-gitignore-file/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oooh - didn't know about that. Thanks.

@jepler jepler merged commit 3922cdd into adafruit:main Jan 2, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jan 4, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM303_Accel to 1.1.9 from 1.1.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_LSM303_Accel#13 from adafruit/dhalbert-ustruct
  > update rtd py version

Updating https://github.com/adafruit/Adafruit_CircuitPython_SHT31D to 2.3.9 from 2.3.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_SHT31D#27 from KeithTheEE/crc_fix

Updating https://github.com/adafruit/Adafruit_CircuitPython_Touchscreen to 1.1.9 from 1.1.8:
  > Merge pull request adafruit/Adafruit_CircuitPython_Touchscreen#19 from CedarGroveStudios/main

Updating https://github.com/adafruit/Adafruit_CircuitPython_Wiznet5k to 1.11.2 from 1.11.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_Wiznet5k#42 from bjnhur/master
  > update rtd py version

Updating https://github.com/adafruit/Adafruit_CircuitPython_PIOASM to 0.5.2 from 0.5.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#32 from dannystaple/patch-1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants