Skip to content

remove printing of MSB, LSB, MID when a single channel is set #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 31, 2019
Merged

remove printing of MSB, LSB, MID when a single channel is set #17

merged 2 commits into from
Jan 31, 2019

Conversation

brentru
Copy link
Member

@brentru brentru commented Jan 31, 2019 •
edited
Loading

Remove the debug prints from the set_channel method, which would display the msb, lsb and mid frequency values.

For example,lora = TinyLoRa(spi, cs, irq, ttn_config, channel = 6) would print:

226
70
140

I'd like to remove the register prints.

@brentru brentru requested a review from a team January 31, 2019 20:22
jerryneedell
jerryneedell reviewed Jan 31, 2019
View reviewed changes
Copy link
Contributor

@jerryneedell jerryneedell left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the change looks good.
On a side note, Is the comment to this section correct -- It says it returns the channel but there is no return - it just sets the frequencies.

Adafruit_CircuitPython_TinyLoRa/adafruit_tinylora/adafruit_tinylora.py

Line 291 in 5627d92

"""Returns the RFM Channel (if single-channel)

@brentru
Copy link
Member Author

brentru commented Jan 31, 2019

@jerryneedell Yep, it only sets and does not return. Modified the comment to reflect this.

jerryneedell
jerryneedell approved these changes Jan 31, 2019
View reviewed changes
Copy link
Contributor

@jerryneedell jerryneedell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! thanks!

@brentru brentru merged commit ab452f9 into adafruit:master Jan 31, 2019
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Feb 2, 2019
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@6bdf304)
9e8bedb 
Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 1.0.1 from 1.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE#9 from dhalbert/improve-uart-example
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE#8 from dhalbert/no-auto-adv-fix-doc

Updating https://github.com/adafruit/Adafruit_CircuitPython_BluefruitConnect to 1.0.6 from 1.0.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_BluefruitConnect#8 from dhalbert/parse_private
  > Merge pull request adafruit/Adafruit_CircuitPython_BluefruitConnect#7 from dhalbert/button-constants

Updating https://github.com/adafruit/Adafruit_CircuitPython_MotorKit to 1.2.4 from 1.2.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_MotorKit#12 from caternuson/dual_step

Updating https://github.com/adafruit/Adafruit_CircuitPython_TinyLoRa to 1.0.7 from 1.0.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_TinyLoRa#18 from brentru/fix-rtd-badge
  > Merge pull request adafruit/Adafruit_CircuitPython_TinyLoRa#17 from brentru/remove-ch-print
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jerryneedell jerryneedell jerryneedell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brentru @jerryneedell