Skip to content

add button constants; improve examples and doc #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 1, 2019
Merged

add button constants; improve examples and doc #7

merged 2 commits into from
Feb 1, 2019

Conversation

dhalbert
Copy link
Contributor

@dhalbert dhalbert commented Feb 1, 2019

  • Add ButtonPacket.B_1, B_2, B_3, B_4, UP, DOWN, LEFT, RIGHT.
  • Remove crickit_test example, since it's now in a guide.
  • Add AccelerometerPacket example.
  • Improve documentation.

@dhalbert dhalbert requested a review from kattni February 1, 2019 15:54
kattni
kattni suggested changes Feb 1, 2019
View reviewed changes
Copy link
Contributor

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! It will make my guide that much easier. I have a couple of thoughts I added below.

@jerryneedell
Copy link
Contributor

tested the PR on feather_nrf52840 ad particle_xenon -- examples worked well! Thanks!

kattni
kattni approved these changes Feb 1, 2019
View reviewed changes
Copy link
Contributor

@kattni kattni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@kattni kattni merged commit edccbe2 into adafruit:master Feb 1, 2019
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Feb 2, 2019
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@6bdf304)
9e8bedb 
Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 1.0.1 from 1.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE#9 from dhalbert/improve-uart-example
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE#8 from dhalbert/no-auto-adv-fix-doc

Updating https://github.com/adafruit/Adafruit_CircuitPython_BluefruitConnect to 1.0.6 from 1.0.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_BluefruitConnect#8 from dhalbert/parse_private
  > Merge pull request adafruit/Adafruit_CircuitPython_BluefruitConnect#7 from dhalbert/button-constants

Updating https://github.com/adafruit/Adafruit_CircuitPython_MotorKit to 1.2.4 from 1.2.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_MotorKit#12 from caternuson/dual_step

Updating https://github.com/adafruit/Adafruit_CircuitPython_TinyLoRa to 1.0.7 from 1.0.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_TinyLoRa#18 from brentru/fix-rtd-badge
  > Merge pull request adafruit/Adafruit_CircuitPython_TinyLoRa#17 from brentru/remove-ch-print
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kattni kattni kattni approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhalbert @jerryneedell @kattni