Skip to content

do not start advertising automatically; update examples; fix doc issues #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 24, 2019

Conversation

dhalbert
Copy link
Collaborator

  • UARTServer() was still calling .start_advertising(). That should have been removed. The user should start advertising explicitly.
  • Fix bugs in examples (including fixing uuid module missing #7).
  • Fix doc bugs and missing entries in api.rst.

@dhalbert dhalbert requested a review from a team January 24, 2019 04:46
@siddacious siddacious merged commit 1bc0f75 into adafruit:master Jan 24, 2019
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Feb 2, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_BLE to 1.0.1 from 1.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE#9 from dhalbert/improve-uart-example
  > Merge pull request adafruit/Adafruit_CircuitPython_BLE#8 from dhalbert/no-auto-adv-fix-doc

Updating https://github.com/adafruit/Adafruit_CircuitPython_BluefruitConnect to 1.0.6 from 1.0.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_BluefruitConnect#8 from dhalbert/parse_private
  > Merge pull request adafruit/Adafruit_CircuitPython_BluefruitConnect#7 from dhalbert/button-constants

Updating https://github.com/adafruit/Adafruit_CircuitPython_MotorKit to 1.2.4 from 1.2.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_MotorKit#12 from caternuson/dual_step

Updating https://github.com/adafruit/Adafruit_CircuitPython_TinyLoRa to 1.0.7 from 1.0.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_TinyLoRa#18 from brentru/fix-rtd-badge
  > Merge pull request adafruit/Adafruit_CircuitPython_TinyLoRa#17 from brentru/remove-ch-print
@dhalbert dhalbert deleted the no-auto-adv-fix-doc branch July 27, 2019 18:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants