use existing spi baudrate instead of hardcoded #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dherrada thanks for the reminder. I definitely missed that message on the issue. Latest commit removes the configure. I don't have hardware to test with and it looks like they are showing out of stock at the moment. I can go back and attempt to make a similar change on the TLC59711 and test it with that device though. |
|
@FoamyGuy Were you ever able to test this? |
|
@dherrada I did test it on a modified branch with the TLC59711 and didn't see any trouble. Though the modified code for it seems to have gotten lost in the shuffle between my old and new laptops. |
|
Awesome. Thanks! |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Dec 19, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_DHT to 3.5.3 from 3.5.2: > Merge pull request adafruit/Adafruit_CircuitPython_DHT#55 from yeyeto2788/fix_issue_54 Updating https://github.com/adafruit/Adafruit_CircuitPython_TLC5947 to 1.3.3 from 1.3.2: > Merge pull request adafruit/Adafruit_CircuitPython_TLC5947#23 from FoamyGuy/fix_hardcoded_baudrate Updating https://github.com/adafruit/Adafruit_CircuitPython_BitbangIO to 1.2.0 from 1.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_BitbangIO#13 from makermelissa/master > Merge pull request adafruit/Adafruit_CircuitPython_BitbangIO#12 from alustig3/master Updating https://github.com/adafruit/Adafruit_CircuitPython_Slideshow to 1.5.1 from 1.5.0: > Merge pull request adafruit/Adafruit_CircuitPython_Slideshow#29 from FoamyGuy/fallback_without_json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #22. I don't have hardware to test it, but wouldn't anticipate problems since it's mostly the same as: #14 from the TLC59711 library.