Skip to content

SPI baudrate hardcoded, should use existing frequency from SPI object #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kattni opened this issue Aug 17, 2020 · 2 comments · Fixed by #23
Closed

SPI baudrate hardcoded, should use existing frequency from SPI object #22

kattni opened this issue Aug 17, 2020 · 2 comments · Fixed by #23
Assignees
Labels
bug Something isn't working

Comments

@kattni
Copy link
Contributor

kattni commented Aug 17, 2020

This is the same issue as adafruit/Adafruit_CircuitPython_TLC59711#8.

Problematic code is here:

self._spi.configure(baudrate=1000000, polarity=0, phase=0, bits=8)

@FoamyGuy Are you up for fixing this like you did the other TLC lib?

@FoamyGuy
Copy link
Contributor

FoamyGuy commented Aug 18, 2020

Yep I can handle it in this library as well.

@tannewt
Copy link
Member

tannewt commented Aug 25, 2020

I think it'd be better to remove the configure all-together if we are assuming the SPI is set up appropriately outside of the driver.

@evaherrada evaherrada added the bug Something isn't working label Sep 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants