Skip to content

Fix issue 54 #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 19, 2020
Merged

Fix issue 54 #55

merged 1 commit into from
Dec 19, 2020

Conversation

yeyeto2788
Copy link

Add NotImplementedError on catched exceptions.

Fixes #54

Add NotImplementedError on catched exceptions.
Copy link
Collaborator

@makermelissa makermelissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I had to look at several of the issues and PRs you referenced to figure out what this was accomplishing. Looks good.

@makermelissa makermelissa merged commit 6400061 into adafruit:master Dec 19, 2020
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Dec 19, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_DHT to 3.5.3 from 3.5.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_DHT#55 from yeyeto2788/fix_issue_54

Updating https://github.com/adafruit/Adafruit_CircuitPython_TLC5947 to 1.3.3 from 1.3.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_TLC5947#23 from FoamyGuy/fix_hardcoded_baudrate

Updating https://github.com/adafruit/Adafruit_CircuitPython_BitbangIO to 1.2.0 from 1.1.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_BitbangIO#13 from makermelissa/master
  > Merge pull request adafruit/Adafruit_CircuitPython_BitbangIO#12 from alustig3/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_Slideshow to 1.5.1 from 1.5.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Slideshow#29 from FoamyGuy/fallback_without_json
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PulseIO NotImplemented Error raised
2 participants