Skip to content

Adds support for the smaller 64x32 ssd1306 displays #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 3, 2020

Conversation

adamcandy
Copy link
Contributor

This is a simple fix to #52.
The values were found from a little experimentation with the displays and are further backed up by COM_PIN_CFG and DISP_CLK_DIV values found in discussions of the ssd1306 online that include reference to the 64x32 display.
I have tested the branch with ssd1306 128x32 and the smaller 64x32 displays and can confirm the fix solves the problem raised in #52 !

The library is great and I look forward to developing further with it for exciting new projects - thanks!

@adamcandy
Copy link
Contributor Author

The discussion here, for example, supports the use of 0x12, not 0x02 (current behaviour) for the COM_PIN_CFG when using the 64x32 display (and also all known ssd1306 displays with a width of 64 pixels).

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit a92acaf into adafruit:master Dec 3, 2020
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Dec 7, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_SI7021 to 3.2.2 from 3.2.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_SI7021#19 from FoamyGuy/remove_busio

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1306 to 2.10.0 from 2.9.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1306#53 from adamcandy/add-64x32-suppoort

Updating https://github.com/adafruit/Adafruit_CircuitPython_MagTag to 1.3.0 from 1.2.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_MagTag#37 from anecdata/patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_MagTag#36 from ladyada/rotate
  > Merge pull request adafruit/Adafruit_CircuitPython_MagTag#33 from adafruit/3.3-battery-voltage
  > Merge pull request adafruit/Adafruit_CircuitPython_MagTag#32 from makermelissa/fontcache
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants