Fix multiplier for battery voltage #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The battery voltage multiplier should be 3.3V, not 2.6V, because `AnalogIn` now compensates for the limited voltage range to some extent. After this fix, the battery voltage is still low by about 0.15V, but I think that's a fix to be made in `AnalogIn`, and will work on that separately.
|
@ladyada If you want this to be more accurate right now, we can add 0.15 to the result here, and then remove that after (if and when) |
ladyada
approved these changes
Dec 4, 2020
makermelissa
approved these changes
Dec 4, 2020
|
the PPK2 has a more-precise voltage output if ya want to try that - the offset is probably what was causing my confusion |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Dec 7, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_SI7021 to 3.2.2 from 3.2.1: > Merge pull request adafruit/Adafruit_CircuitPython_SI7021#19 from FoamyGuy/remove_busio Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1306 to 2.10.0 from 2.9.2: > Merge pull request adafruit/Adafruit_CircuitPython_SSD1306#53 from adamcandy/add-64x32-suppoort Updating https://github.com/adafruit/Adafruit_CircuitPython_MagTag to 1.3.0 from 1.2.0: > Merge pull request adafruit/Adafruit_CircuitPython_MagTag#37 from anecdata/patch-1 > Merge pull request adafruit/Adafruit_CircuitPython_MagTag#36 from ladyada/rotate > Merge pull request adafruit/Adafruit_CircuitPython_MagTag#33 from adafruit/3.3-battery-voltage > Merge pull request adafruit/Adafruit_CircuitPython_MagTag#32 from makermelissa/fontcache
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The battery voltage multiplier should be 3.3V, not 2.6V, because
AnalogInnow compensates for the limited voltage range to some extent.After this fix, the battery voltage is still low by about 0.15V, but I think that's a fix to be made in
AnalogIn, and will work on that separately.