Skip to content

use board.I2C() instead of busio in the example script #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 6, 2020

Conversation

FoamyGuy
Copy link
Contributor

@FoamyGuy FoamyGuy commented Dec 6, 2020

pylint also complained about missing docstring, so I added that as well.

Tested successfully with Adafruit CircuitPython 6.1.0-beta.1 on 2020-11-20; MagTag with ESP32S2 and the SI7021 breakout.

@FoamyGuy FoamyGuy requested a review from a team December 6, 2020 16:29
Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dhalbert dhalbert merged commit b79e60f into adafruit:master Dec 6, 2020
@FoamyGuy FoamyGuy deleted the remove_busio branch December 6, 2020 18:24
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Dec 7, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_SI7021 to 3.2.2 from 3.2.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_SI7021#19 from FoamyGuy/remove_busio

Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1306 to 2.10.0 from 2.9.2:
  > Merge pull request adafruit/Adafruit_CircuitPython_SSD1306#53 from adamcandy/add-64x32-suppoort

Updating https://github.com/adafruit/Adafruit_CircuitPython_MagTag to 1.3.0 from 1.2.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_MagTag#37 from anecdata/patch-1
  > Merge pull request adafruit/Adafruit_CircuitPython_MagTag#36 from ladyada/rotate
  > Merge pull request adafruit/Adafruit_CircuitPython_MagTag#33 from adafruit/3.3-battery-voltage
  > Merge pull request adafruit/Adafruit_CircuitPython_MagTag#32 from makermelissa/fontcache
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants