Skip to content
This repository was archived by the owner on Apr 20, 2022. It is now read-only.

Allow setting RGBW pixels with RGB tuples #20

Merged
merged 2 commits into from
Jun 22, 2020
Merged

Allow setting RGBW pixels with RGB tuples #20

merged 2 commits into from
Jun 22, 2020

Conversation

dunkmann00
Copy link
Contributor

This change mirrors the change made in CP for pixelbuf #2954

@dhalbert dhalbert requested a review from rhooper May 29, 2020 17:13
@dunkmann00
Copy link
Contributor Author

@kattni Have you been able to check this one over?

@rhooper
Copy link
Contributor

rhooper commented Jun 9, 2020

This looks good, and works.
It might be worth updating the simpletest to exercise this.

buf = TestBuf(20, "RGBW", 1.0, auto_write=True)
buf[0] = (1, 2, 3)
buf[1] = (1, 2, 3, 4)
buf[2] = (2, 2, 2)

had the expected results.

rhooper
rhooper approved these changes Jun 9, 2020
View reviewed changes
Copy link
Contributor

@rhooper rhooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look good and work.

@dunkmann00
Copy link
Contributor Author

Sorry for taking so long, but I added the changes @rhooper suggested into simpletest

@dunkmann00 dunkmann00 requested a review from rhooper June 19, 2020 19:25
rhooper
rhooper approved these changes Jun 19, 2020
View reviewed changes
Copy link
Contributor

@rhooper rhooper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for making Pypixelbuf behave the same as _pixelbuf!

@tannewt tannewt merged commit 1c31111 into adafruit:master Jun 22, 2020
@dunkmann00 dunkmann00 deleted the rgb-for-rgbw branch June 23, 2020 01:04
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jun 26, 2020
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@b025932)
1e87f65 
Updating https://github.com/adafruit/Adafruit_CircuitPython_BMP280 to 3.2.2 from 3.2.1:
  > Merge pull request adafruit/Adafruit_CircuitPython_BMP280#25 from FoamyGuy/fix_readme

Updating https://github.com/adafruit/Adafruit_CircuitPython_RGB_Display to 3.10.0 from 3.9.3:
  > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#82 from makermelissa/master

Updating https://github.com/adafruit/Adafruit_CircuitPython_ImageLoad to 0.11.0 from 0.10.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#32 from FoamyGuy/handle_longint_missing_error
  > Revert "refactor negative height check into its own file"
  > refactor negative height check into its own file
  > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#31 from FoamyGuy/fix_simpletest
  > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#29 from adafruit/setup-py-disabled
  > build.yml: add black formatting check

Updating https://github.com/adafruit/Adafruit_CircuitPython_Pypixelbuf to 2.1.0 from 2.0.0:
  > Merge pull request adafruit/Adafruit_CircuitPython_Pypixelbuf#20 from dunkmann00/rgb-for-rgbw
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rhooper rhooper rhooper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dunkmann00 @rhooper @tannewt