Fix for builds without longint #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Catch overflow on devices without longint
|
It looks like there is still some sort of trouble to sort out with this PR. I just ran into this error with it: I will look into it. |
evaherrada
approved these changes
Jun 25, 2020
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Jun 26, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_BMP280 to 3.2.2 from 3.2.1: > Merge pull request adafruit/Adafruit_CircuitPython_BMP280#25 from FoamyGuy/fix_readme Updating https://github.com/adafruit/Adafruit_CircuitPython_RGB_Display to 3.10.0 from 3.9.3: > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#82 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_ImageLoad to 0.11.0 from 0.10.0: > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#32 from FoamyGuy/handle_longint_missing_error > Revert "refactor negative height check into its own file" > refactor negative height check into its own file > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#31 from FoamyGuy/fix_simpletest > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#29 from adafruit/setup-py-disabled > build.yml: add black formatting check Updating https://github.com/adafruit/Adafruit_CircuitPython_Pypixelbuf to 2.1.0 from 2.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_Pypixelbuf#20 from dunkmann00/rgb-for-rgbw
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #28
This change refactors negative height check into its own file in order to avoid using
0x7FFFFFFFaltogether on builds without longint. This allows it to avoid a seemingly un-catchable overflow error.I am very open to other ways to achieve this library working on devices without longint and continuing to work correctly with negative height bmp files on builds that do have longint. This was the only thing I managed to come up with that was working.
If you try to use load a negative bmp on a build without longint now you get this error:
If you load a negative bmp on a build with longint it will correctly show the image.
These changes were tested on EdgeBadge and PewPew M4 respectively using the image file linked in #18