Fix readme example #25
Conversation
examples/bmp280_simpletest.py
Outdated
| i2c = busio.I2C(board.SCL, board.SDA) # pylint: disable=invalid-name | ||
| bmp280 = adafruit_bmp280.Adafruit_BMP280_I2C(i2c) # pylint: disable=invalid-name |
There was a problem hiding this comment.
Examples should be exempt from these checks: https://github.com/adafruit/Adafruit_CircuitPython_BMP280/blob/master/.github/workflows/build.yml#L52
There was a problem hiding this comment.
Thank you Scott
When I check pylint locally I use a command like this:
pylint --rcfile .pylintrc path\to\somefile.py
I don't have much experience with the github workflows like this forgive me if it's obvious, but I don't see any reference to the .pylintrc file around that section you linked to.
Is the command like I've used here the correct way for me to check pylint locally?
Is there a different .pylintrc for the examples? or do they skip pylinting entirely?
There was a problem hiding this comment.
@FoamyGuy if you look at https://github.com/adafruit/Adafruit_CircuitPython_BMP280/blob/master/.github/workflows/build.yml#L52 you can see the pylon command used for the examples.
There was a problem hiding this comment.
Ah, I think I get it now, there are a few extra things disabled via the flag --disable=missing-docstring,invalid-name,bad-whitespace passed in when it's run. Thank you Jerry.
I pushed a change to remove them from the example script the other day. But I just noticed that I've left them in the readme. I'll push another commit to fix that shortly.
Updating https://github.com/adafruit/Adafruit_CircuitPython_BMP280 to 3.2.2 from 3.2.1: > Merge pull request adafruit/Adafruit_CircuitPython_BMP280#25 from FoamyGuy/fix_readme Updating https://github.com/adafruit/Adafruit_CircuitPython_RGB_Display to 3.10.0 from 3.9.3: > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#82 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_ImageLoad to 0.11.0 from 0.10.0: > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#32 from FoamyGuy/handle_longint_missing_error > Revert "refactor negative height check into its own file" > refactor negative height check into its own file > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#31 from FoamyGuy/fix_simpletest > Merge pull request adafruit/Adafruit_CircuitPython_ImageLoad#29 from adafruit/setup-py-disabled > build.yml: add black formatting check Updating https://github.com/adafruit/Adafruit_CircuitPython_Pypixelbuf to 2.1.0 from 2.0.0: > Merge pull request adafruit/Adafruit_CircuitPython_Pypixelbuf#20 from dunkmann00/rgb-for-rgbw
Fixes #24
This change updates the readme example to use code from simpletest. Also Fixes a few pylint ssues in simpletest.
Tested on CLUE