Raise error on HTTP Error and fix json w/ no path #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, the reason it was causing a problem now is because in this condition it would read r.json() followed by r.text. This fixes it. |
|
Excellent, this appears to have fixed the issues I was facing with the weather station. Thank you! |
|
Thanks for testing @joelguth. |
tannewt
approved these changes
Nov 6, 2020
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Nov 7, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_BNO055 to 5.2.2 from 5.2.1: > Merge pull request adafruit/Adafruit_CircuitPython_BNO055#60 from adafruit/fix-super-call Updating https://github.com/adafruit/Adafruit_CircuitPython_ESP32SPI to 3.5.3 from 3.5.2: > Merge pull request adafruit/Adafruit_CircuitPython_ESP32SPI#114 from tannewt/esp32spi_fixes Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS3DH to 5.1.5 from 5.1.4: > Merge pull request adafruit/Adafruit_CircuitPython_LIS3DH#63 from adafruit/ladyada-patch-3 Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 3.6.2 from 3.6.1: > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#93 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.9.3 from 2.9.2: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#96 from FoamyGuy/add_matrixportal_example Updating https://github.com/adafruit/Adafruit_CircuitPython_MatrixPortal to 1.9.0 from 1.8.4: > Merge pull request adafruit/Adafruit_CircuitPython_MatrixPortal#38 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_miniesptool to 0.2.5 from 0.2.4: > Merge pull request adafruit/Adafruit_CircuitPython_miniesptool#23 from adafruit/nina-fw-1.7.1-updates Updating https://github.com/adafruit/Adafruit_CircuitPython_Requests to 1.7.5 from 1.7.4: > Merge pull request adafruit/Adafruit_CircuitPython_Requests#50 from tannewt/better_error_handling > Merge pull request adafruit/Adafruit_CircuitPython_Requests#49 from adafruit/no-https-wifitest > Merge pull request adafruit/Adafruit_CircuitPython_Requests#45 from tannewt/fix_close
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #92. I also am raising an error for HTTP errors. The reason for this is it was returning None and later in the code giving an unrelated confusing message.
The bulk of this PR is if no Path is defined, values was an empty list and code that was written such as the weather station expected the JSON as a string to be returned. I realize loading json and using json.dumps() uses more memory, but rather than only grabbing r.text if there was no path, I didn't want to break it if the json_transform was provided which expects a dict. However, it won't load json until it actually has to so it only does it for the single edge case.